-
Notifications
You must be signed in to change notification settings - Fork 427
Add support for Canonical MaaS Provider #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @vasartori. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b2adecb
to
5e7718d
Compare
@AverageMarcus Could you please take a look at this PR and review it? I probably forgot somethig, and you have more experience than me with image-builder. |
/ok-to-test |
/retest |
4c576b6
to
a6c4596
Compare
@mboersma @AverageMarcus @drew-viles
|
|
@vasartori we can't merge this until the As for the README.md, I think it should go at images/capi/packer/maas/README.md where you put it, and that content looks good to me. |
@mboersma and @drew-viles, after a long time, I’ve started the request to join the Kubernetes SIG as a member. |
Hello @mboersma and @drew-viles, |
Sorry for the delay @vasartori , super busy at the moment. Yes please also update the Owners so that you can be pinged if any changes come into this area of the repo. |
137f5c0
to
cbd9669
Compare
@drew-viles All done! I believe we are now ready to merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @AverageMarcus @mboersma
Change description
Add support for Canonica MaaS
Related issues
Additional context
Initially, this version supports only Ubuntu 22.04 and Ubuntu 24.04, both in the UEFI version.
After some time, we can start adding other operating systems, such as Rocky Linux 9.