-
Notifications
You must be signed in to change notification settings - Fork 652
test: AttachedRoutes conformance tests to count only Accepted routes #4362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test: AttachedRoutes conformance tests to count only Accepted routes #4362
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidesalerno The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @davidesalerno. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test This was discussed in the December 8th Gateway API meeting and the proposed clarification of only counting |
|
/test pull-gateway-api-verify seems like one of the flakes when trying to use prow to build arm images |
87f4c78 to
08e872e
Compare
snorwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidesalerno.
Did you have a chance to verify this PR against any implementation?
Our implementation (Airlock Microgateway) does not pass it due to the issue noted in my comment.
I highly recommend that, if you plan to make further contributions to the conformance tests, you set up an environment where you can run them against at least one implementation. This doesn’t mean all implementations are perfect, but it does provide a useful indicator and helps catch issues early.
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: http-route-not-accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this HTTPRoute supposed to be not accepted? For example, a route is not accepted if the listener hostname does not match the route hostnames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling some commit is lost here, previously there was something else making it not accepted
Signed-off-by: Davide Salerno <[email protected]>
08e872e to
3e31fe6
Compare
What type of PR is this?
/kind test
Optionally add one or more of the following kinds if applicable:
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4341
Does this PR introduce a user-facing change?: