Skip to content

Add conformance report for Traefik Proxy #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2025
Merged

Add conformance report for Traefik Proxy #4207

merged 3 commits into from
Nov 4, 2025
+102 −2

Conversation

@kevinpollet
Copy link
Contributor

@kevinpollet kevinpollet commented Oct 29, 2025

What type of PR is this?

/kind documentation
/area conformance-test

What this PR does / why we need it:

This pull request adds the conformance report for v1.4.0 for Traefik Proxy.

Does this PR introduce a user-facing change?:

Add conformance report for v1.4.0 for Traefik Proxy

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 29, 2025

Hi @kevinpollet. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snorwin
Copy link
Member

snorwin commented Oct 29, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
robscott
robscott approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinpollet!

conformance/reports/v1.4.0/traefik-traefik/experimental-v3.6.0-default-report.yaml Outdated
@@ -0,0 +1,71 @@
apiVersion: gateway.networking.k8s.io/v1
date: '-'
Copy link
Member

@robscott robscott Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intent here is to indicate when the tests were run

Copy link
Member

@robscott robscott Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be automatically populated when our tests generate the conformance report - was there a bug here? Or was this file generated some other way?

Copy link
Contributor Author

@kevinpollet kevinpollet Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today, our CI checks that the committed conformance report matches the one generated during the CI job. To avoid date differences, we explicitly set the date to - (see https://github.com/traefik/traefik/blob/v3.6/integration/gateway_api_conformance_test.go#L210).

I will update the report with the proper date, and we’ll look into possible ways to prevent this issue in the future.

conformance/reports/v1.4.0/traefik-traefik/README.md
@@ -0,0 +1,29 @@
# Traefik Proxy
Copy link
Member

@robscott robscott Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend updating the implementations.md list as well to bump your conformant status to v1.4.

Copy link
Contributor Author

@kevinpollet kevinpollet Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I updated the implementations.md list accordingly.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@kevinpollet kevinpollet force-pushed the traefik-conformance-1.4.0 branch from ac072b6 to 33d643a Compare October 31, 2025 08:51
robscott
robscott approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinpollet!

/lgtm

site-src/implementations.md

### Traefik Proxy

[![Conformance](https://img.shields.io/badge/Gateway%20API%20Conformance%20v1.3.0-Traefik Proxy-green)](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/reports/v1.3.0/traefik-traefik)
Copy link
Member

@robscott robscott Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done in a follow up, will merge as is so this gets in in time for blog post deadline.

Suggested change
[![Conformance](https://img.shields.io/badge/Gateway%20API%20Conformance%20v1.4.0-Traefik Proxy-green)](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/reports/v1.4.0/traefik-traefik)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinpollet, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7589ab2 into kubernetes-sigs:main Nov 4, 2025
8 checks passed
@nmengin nmengin mentioned this pull request Nov 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robscott robscott robscott approved these changes

@howardjohn howardjohn Awaiting requested review from howardjohn

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees

@robscott robscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinpollet @k8s-ci-robot @snorwin @robscott