Enable Kubernetes API Linter #3917
Open
+68
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
JoelSpeed
reviewed
Jul 15, 2025
shaneutt
approved these changes
Jul 15, 2025
|
|
||
| jobs: | ||
| golangci: | ||
| name: lint |
There was a problem hiding this comment.
Suggested change
| name: lint | |
| name: kube-api-lint |
k8s-ci-robot
added
the
approved
robscott
approved these changes
Jul 16, 2025
| - name: Build KAL | ||
| run: golangci-lint custom | ||
| - name: run api linter | ||
| run: ./bin/golangci-kube-api-linter run -c ./.golangci-kal.yml ./... |
There was a problem hiding this comment.
Don't forget trailing new line here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What this PR does / why we need it: This PR enables Kube API Linter with a small set of validations. The enabled validations doesn't present a breaking change on existing APIs, and the plan is to progressively enable other linters that may present more disrupting changes on follow up PRs after discussion with Gateway API group.
Does this PR introduce a user-facing change?:
Note for reviewers:
The ongoing discussion is part of the document https://docs.google.com/document/d/1DSyP7Vt9E9wX2ku1C0AvCLqQe9cCiDPCLiPP0wXFYQw/edit?tab=t.0 and the thread https://kubernetes.slack.com/archives/CR0H13KGA/p1751923997220399
The proposed changes on this PR contains fix for validations that are not breaking change, and are separated on different commits per enabled linter.
For newer validations, we should enable the linters just for new changes and existing violations should be fixed individually as they may not break existing GA'd APIs.
This run contains the execution of the linter as per this PR without enabling the feature for only changed files, showing that the enabled linters don't trigger any violation.