-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add new flag to allow configuring per pod FQDNs for service source. #5938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add new flag to allow configuring per pod FQDNs for service source. #5938
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @SerjKol80! |
|
Hi @SerjKol80. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
11db843 to
d4ad7d8
Compare
d4ad7d8 to
dc4db1b
Compare
dc4db1b to
214b916
Compare
|
What for? There is FQDN support https://github.com/kubernetes-sigs/external-dns/blob/master/docs/advanced/fqdn-templating.md. Is way more flexible |
What does it do ?
Currently if you create FQDNs for K8S headless services, a service source will generate DNS record for the source. Also, in addition to that, if pods related to that service has a hostname configured, then FQDNs for each pod will also be created.
I.e. if you have service
service-1resulting into FQDNservice-1.some.domainthere will also be FQDNs likepod-1.service-1.some.domainbe generated.With this change
Fixes #5937
Motivation
I need to generate per pod FQDNs for pods created by Deployment.
More