Skip to content

Conversation

@SerjKol80
Copy link

What does it do ?

Currently if you create FQDNs for K8S headless services, a service source will generate DNS record for the source. Also, in addition to that, if pods related to that service has a hostname configured, then FQDNs for each pod will also be created.
I.e. if you have service service-1 resulting into FQDN service-1.some.domain there will also be FQDNs like pod-1.service-1.some.domain be generated.

With this change

Fixes #5937

Motivation

I need to generate per pod FQDNs for pods created by Deployment.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SerjKol80 / name: Sergey Kolosov (214b916)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added apis Issues or PRs related to API change docs cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. source labels Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @SerjKol80!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @SerjKol80. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2025
@SerjKol80 SerjKol80 force-pushed the sergey-kolosov/per-pods-fqdn branch 2 times, most recently from 11db843 to d4ad7d8 Compare November 4, 2025 22:16
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 4, 2025
@SerjKol80 SerjKol80 force-pushed the sergey-kolosov/per-pods-fqdn branch from d4ad7d8 to dc4db1b Compare November 5, 2025 00:41
@SerjKol80 SerjKol80 force-pushed the sergey-kolosov/per-pods-fqdn branch from dc4db1b to 214b916 Compare November 5, 2025 00:58
@ivankatliarchuk
Copy link
Member

What for? There is FQDN support https://github.com/kubernetes-sigs/external-dns/blob/master/docs/advanced/fqdn-templating.md. Is way more flexible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apis Issues or PRs related to API change cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add new flag to allow configuring per pod FQDNs for service source.

3 participants