-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(registry): new CRD option #5372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mloiseleur
wants to merge
7
commits into
kubernetes-sigs:master
Choose a base branch
from
mloiseleur:feat/crd-registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,398
−14
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
04d61c9
feat(registry): new CRD option
mloiseleur 9dc1993
fix linters
mloiseleur f260e1c
main integration + first test review
mloiseleur 36b78a2
self-review
mloiseleur 4ed8519
move code to apis/v1alpha1
mloiseleur b2b9e24
self-review
mloiseleur c91fb32
make lint
mloiseleur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v1alpha1 | ||
|
||
import ( | ||
"strings" | ||
|
||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
"sigs.k8s.io/external-dns/endpoint" | ||
) | ||
|
||
const ( | ||
RecordOwnerLabel string = "externaldns.k8s.io/owner" | ||
RecordNameLabel string = "externaldns.k8s.io/record-name" | ||
RecordTypeLabel string = "externaldns.k8s.io/record-type" | ||
RecordIdentifierLabel string = "externaldns.k8s.io/identifier" | ||
RecordResourceLabel string = "externaldns.k8s.io/resource" | ||
) | ||
|
||
// DNSRecordSpec defines the desired state of DNSEndpoint | ||
// +kubebuilder:object:generate=true | ||
type DNSRecordSpec struct { | ||
Endpoint endpoint.Endpoint `json:"endpoints,omitempty"` | ||
} | ||
|
||
// DNSRecordStatus defines the observed state of DNSRecord | ||
// +kubebuilder:object:generate=true | ||
type DNSRecordStatus struct { | ||
// The generation observed by the external-dns controller. | ||
// +optional | ||
ObservedGeneration int64 `json:"observedGeneration,omitempty"` | ||
} | ||
|
||
// +genclient | ||
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
||
// DNSRecord is used to get all records managed by external-dns. | ||
// It can be used as a registry with the status subresource. | ||
// +k8s:openapi-gen=true | ||
// +groupName=externaldns.k8s.io | ||
// +kubebuilder:resource:path=dnsrecords | ||
// +kubebuilder:object:root=true | ||
// +kubebuilder:subresource:status | ||
// +versionName=v1alpha1 | ||
|
||
type DNSRecord struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
Spec DNSRecordSpec `json:"spec,omitempty"` | ||
Status DNSRecordStatus `json:"status,omitempty"` | ||
} | ||
|
||
// +kubebuilder:object:root=true | ||
// DNSEndpointList is a list of DNSEndpoint objects | ||
type DNSRecordList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
Items []DNSRecord `json:"items"` | ||
} | ||
|
||
func (dr DNSRecord) IsEndpoint(e *endpoint.Endpoint) bool { | ||
spec := dr.Spec.Endpoint | ||
|
||
return spec.DNSName == strings.ToLower(e.DNSName) && | ||
spec.RecordType == e.RecordType && | ||
spec.SetIdentifier == e.SetIdentifier | ||
} | ||
|
||
func (dr DNSRecord) EndpointLabels() endpoint.Labels { | ||
labels := endpoint.Labels{} | ||
|
||
labels[endpoint.OwnerLabelKey] = dr.Labels[RecordOwnerLabel] | ||
labels[endpoint.ResourceLabelKey] = dr.Labels[RecordResourceLabel] | ||
return labels | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CRDs for the Helm chart should be in separate files and be formatted as described in #5479. The following command would be my suggestion to handle multiple CRDs being generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed with a rebase.