🌱 Fix flaky test in extensionconfig_controller_test.go

[Okabe-Junya]

What this PR does

Fixed a flaky test - TestExtensionReconciler_Reconcile by adding proper sync to wait for both Paused and Discovery conditions to be set before performing assertions

why we need it

The paused.EnsurePausedCondition() function triggers multiple reconciliation cycles:

1. Sets PausedV1Beta2Condition and returns requeue=true (early return)
2. Executes discovery logic and sets ExtensionConfigDiscoveredV1Beta2Condition

The test assertion g.Expect(v1beta2Conditions).To(HaveLen(2)) was executed immediately after the second reconcile call, but before the patch containing the Discovery condition was fully applied to the API server (race condition I think).

So we need to Eventually block to resolve this race condition

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12311

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Okabe-Junya]

/test all

[Okabe-Junya]

/area ci
/area testing

[Okabe-Junya]

/retitle 🌱 Fix flaky test in extensionconfig_controller_test.go

[mboersma]

I think this attempts to fix #12311.

[Okabe-Junya]

I think this attempts to fix #12311.

Yes, I couldn't find time to resolve the CI error.
I'll check it out for now. Once CI passes, I'll mark the PR as ready for review and link it to the issue :)

[Okabe-Junya]

Still occurring a CI error, but I'm not sure of the cause.
The method seems to be implemented, and running make lint locally doesn't detect any errors. It appears to be a problem with type inference, but I haven't pin-pointed the exact cause yet...

 Error: exp/runtime/internal/controllers/extensionconfig_controller_test.go:131:39: updatedConfig.GetV1Beta2Conditions undefined (type *"sigs.k8s.io/cluster-api/api/runtime/v1beta2".ExtensionConfig has no field or method GetV1Beta2Conditions) (typecheck)

[sbueringer]

Did you already rebase on top of main? CI is running based on latest main + the PR

[Okabe-Junya]

Did you already rebase on top of main? CI is running based on latest main + the PR

Yes, already rebase with fresh main...
(Will take a look this error in this weekend 🙇 )

[sbueringer]

Yes, already rebase with fresh main...

I think something went wrong there (see 26.03.2025)

[Okabe-Junya]

I think something went wrong there (see 26.03.2025)

Oh, I'm really sorry...

I had mistakenly set up the upstream configuration on my machine (just for this repo), and origin/main wasn't fetching correctly for a while.
It seems I've been working off an old main branch... 🙇

I've rebased on the latest main now. All CIs seems to be working well :)
Could you please review?