Bump QPS and burst for kube-controller-manager in DRA load test #5746
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
/test ? |
k8s-ci-robot
added
the
size/S
|
@nojnhuh: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
/cc @alaypatel07 |
|
@nojnhuh: GitHub didn't allow me to request PR reviews from the following users: alaypatel07. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5746 +/- ##
==========================================
- Coverage 52.84% 52.82% -0.02%
==========================================
Files 278 279 +1
Lines 29610 29629 +19
==========================================
+ Hits 15647 15652 +5
- Misses 13146 13160 +14
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am unsure why the dra lane has started to fail: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5746/pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds/1944640471062024192 The error is something like this: The same failure is also seen in the periodics:
The first known failure from periodic was from 7:31 PM EDT, on 07/11. @jackfrancis @nojnhuh would you have any idea about why this is failing? |
We were up against our max quota but things are looking better now. /test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
got another failure, and looks like the changes did not get applied as intended: EDIT: looks like I was looking at an older run, I will wait for the new run here: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5746/pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds/1944803095330426880 |
|
@nojnhuh is this another failure failure hitting quota limits https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5746/pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds/1944803095330426880? how can we make sure we get some guaranteed time for iterating on dra jobs? |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
1 similar comment
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
Looks like this is working as intended. /assign @Jont828 |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
@nojnhuh https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5746/pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds/1945527196135198720 The prometheus setup on this jobs is failing because PVC attachment is failing. Can you please look into it? This is blocking stabilizing the 100 node azure test. |
|
/retest |
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
nojnhuh
force-pushed
the
dra-ctrl-qps-burst
branch
from
eb80a31 to
6e67ee2
Compare
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
nojnhuh
force-pushed
the
dra-ctrl-qps-burst
branch
from
6e67ee2 to
48e3e20
Compare
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
nojnhuh
force-pushed
the
dra-ctrl-qps-burst
branch
from
48e3e20 to
3f5d5e4
Compare
|
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8e8b1fc0e5a0997b69aa2c10d4e06d3336866c07
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps QPS and burst for kube-controller-manager to meet load test demands.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5745
Special notes for your reviewer:
TODOs:
Release note: