Enable resource.k8s.io/v1beta2 for DRA templates #5731
Conversation
k8s-ci-robot
added
release-note-none
|
/test ? |
k8s-ci-robot
added
the
cncf-cla: yes
|
@nojnhuh: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
/cherry-pick release-1.20 We want to make this available for the SIG Scalability DRA tests on a release branch of CAPZ. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5731 +/- ##
=======================================
Coverage 52.83% 52.84%
=======================================
Files 278 278
Lines 29610 29610
=======================================
+ Hits 15645 15647 +2
+ Misses 13148 13146 -2
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold This is a good chance to test the new jobs that will land in kubernetes/test-infra#35054 |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test ? |
|
@nojnhuh: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds |
|
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds failed, but it failed the same way as its periodic counterpart, so I think we're good to go. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 68a927a1228a38e65e8fff92119190ea61c3cd28
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@nojnhuh: new pull request created: #5736 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR enables the v1beta2 API for the DRA-enabled templates in addition to v1beta1, which is still required. This means the implicit minimum Kubernetes version for these templates is 1.33. That shouldn't be an issue since we only test k/k at
masterwith these templates IIRC.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: