-
Notifications
You must be signed in to change notification settings - Fork 614
✨ Migrate Node packages to AWS SDK v2 #5584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @LiangquanLi930! |
Hi @LiangquanLi930. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@damdo Hi, I have a question I'd like to ask — regarding cluster-api-provider-aws/pkg/cloud/interfaces.go Lines 33 to 38 in 701052c
as part of this issue we’re trying to address? |
@LiangquanLi930: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hey @LiangquanLi930 I don't think so, but better to ask @punkwalker |
I saw #5521 — maybe we should wait for this PR to merge before proceeding with ours. |
Yeah, that's probably better, let's pause this until we get the other in, thanks @LiangquanLi930 |
@LiangquanLi930 @damdo The session() can only be removed if all the dependent clients are migrated to SDK V2. Let’s wait for #5521 to merge and then cleanup every reference to SDK v1 sessions. |
What type of PR is this?
Add one of the following kinds:
/kind feature
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5402
Special notes for your reviewer:
Checklist:
Release note: