Skip to content

🌱 Migrate gc to aws sdk v2 #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🌱 Migrate gc to aws sdk v2 #5518

wants to merge 2 commits into from
+1,197 −240

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Jun 3, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate ELB garbage collection to AWS SDK v2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5406

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Migrate ELB garbage collection to AWS SDK v2

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/support Categorizes issue or PR as a support question. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from 7b8080f to 1822ed1 Compare June 3, 2025 19:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from 1822ed1 to adc451e Compare June 3, 2025 19:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from a75be30 to b39b276 Compare June 4, 2025 06:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2025
@Danil-Grigorev Danil-Grigorev changed the title [WIP] Migrate gc to aws sdk v2 🌱 Migrate gc to aws sdk v2 Jun 4, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 4, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch 5 times, most recently from fccf39b to 12a5c0a Compare June 4, 2025 07:04
@Danil-Grigorev
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks
/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 4, 2025
@Danil-Grigorev Danil-Grigorev mentioned this pull request Jun 4, 2025
Open
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from 12a5c0a to 2cfd1e6 Compare June 4, 2025 08:28
@damdo
Copy link
Member

damdo commented Jun 4, 2025

/assign @nrb

alexander-demicev
alexander-demicev approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cef4df8dd78cc2740930f3275f6bb2f33d481ebf

@alexander-demicev
Copy link
Contributor

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@damdo damdo requested a review from nrb June 26, 2025 10:14
@damdo
Copy link
Member

damdo commented Jun 26, 2025

/hold

for testing to pass

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2025
richardcase
richardcase reviewed Jun 26, 2025
View reviewed changes
@damdo damdo requested a review from richardcase June 26, 2025 14:39
AndiDog
AndiDog reviewed Jun 26, 2025
View reviewed changes
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from c2c6a4d to 5012b2c Compare June 27, 2025 11:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from 5012b2c to 8ee8a1e Compare June 27, 2025 11:27
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2025
@damdo
Copy link
Member

damdo commented Jun 30, 2025

@Danil-Grigorev would you be able to rebase? Thanks!

@Danil-Grigorev
Refactor: Migrate GC service to AWS SDK v2
717f865 
Migrate the garbage collection service and related components to use the AWS SDK v2.
This involves updating dependencies, refactoring client initialization, and updating API calls within the GC logic.
Adds new v2 specific converters, filters, and mocks.

Migrate the garbage collection logic for AWS Application Load Balancers (ALBs) and Network Load Balancers (NLBs) to use the AWS SDK v2.

Migrate the garbage collection logic for Classic Load Balancers (ELB) from the AWS SDK v1 to v2.

Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Update licence year, address review
b2546a6 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev Danil-Grigorev force-pushed the migrate-gc-to-aws-sdk-v2 branch from 8ee8a1e to b2546a6 Compare July 4, 2025 07:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2025
@damdo
Copy link
Member

damdo commented Jul 4, 2025

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@AndiDog @richardcase @alexander-demicev
Would you be able to add your labels if happy with the latest changes?
Thanks!

@alexander-demicev
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c405f40beccd5fe2d15e9c1f73b26d9148c70b10

@damdo
Copy link
Member

damdo commented Jul 4, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member

damdo commented Jul 4, 2025

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@damdo
Copy link
Member

damdo commented Jul 4, 2025

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot
Copy link
Contributor

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e b2546a6 link false /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@nrb nrb Awaiting requested review from nrb

@richardcase richardcase Awaiting requested review from richardcase

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@AndiDog AndiDog Awaiting requested review from AndiDog

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@alexander-demicev alexander-demicev

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate gc code to AWS SDK v2
9 participants
@Danil-Grigorev @damdo @alexander-demicev @k8s-ci-robot @richardcase @yiannistri @nrb @AndiDog @dlipovetsky