fix(sdk): use local wheels for regression tests#12929
fix(sdk): use local wheels for regression tests#12929rishabh998186 wants to merge 3 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Pipelines repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. |
|
Hi @rishabh998186. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI failure that occurs during version bumps when the KFP SDK references a version of kfp-server-api that hasn't been published to PyPI yet. The issue manifested in regression tests that use Docker containers, where pip would fail to resolve the unreleased kfp-server-api dependency.
Changes:
- Build and use local kfp wheel for regression tests instead of git URL to avoid PyPI dependency resolution
- Pre-install kfp-server-api from local source in all SDK test scripts before installing the main SDK package
- Add python build module to test dependencies
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/presubmit-tests-sdk.sh | Added build module installation, local kfp-server-api installation, and local wheel building logic to replace git URL-based KFP_PACKAGE_PATH |
| test/presubmit-tests-sdk-unit.sh | Added local kfp-server-api installation before SDK installation |
| test/presubmit-tests-sdk-client.sh | Added local kfp-server-api installation before SDK installation |
Signed-off-by: rishabh998186 <rishabh998186@gmail.com.com>
7086f16 to
d61ae8d
Compare
|
@droctothorpe , |
Description
This PR resolves the "Missing distribution found" error that occurs during release version bumps (e.g., to 2.16.0) when kfp-server-api has not yet been published to PyPI.
Root Cause
The
TestDockerRunnertests previously used a git URL for KFP_PACKAGE_PATH. When component containers ran, pip tried to resolve the new version of kfp-server-api from PyPI and failed.fix
test/presubmit-tests-sdk.shto build a local kfp wheel and setKFP_PACKAGE_PATHto the local path.kfp-server-apifrom local source (backend/api/v2beta1/python_http_client).pipsatisfies dependency constraints using local artifacts instead of hitting PyPI.fixes #12906