Skip to content

fix(sdk): use local wheels for regression tests#12929

Open
rishabh998186 wants to merge 3 commits intokubeflow:masterfrom
rishabh998186:fix/sdk-tests-use-local-wheel-12906
Open

fix(sdk): use local wheels for regression tests#12929
rishabh998186 wants to merge 3 commits intokubeflow:masterfrom
rishabh998186:fix/sdk-tests-use-local-wheel-12906

Conversation

@rishabh998186
Copy link
Contributor

Description

This PR resolves the "Missing distribution found" error that occurs during release version bumps (e.g., to 2.16.0) when kfp-server-api has not yet been published to PyPI.

Root Cause

The TestDockerRunner tests previously used a git URL for KFP_PACKAGE_PATH. When component containers ran, pip tried to resolve the new version of kfp-server-api from PyPI and failed.

fix

  • Updated test/presubmit-tests-sdk.sh to build a local kfp wheel and set KFP_PACKAGE_PATH to the local path.
  • Updated all SDK test scripts ( presubmit-tests-sdk.sh, presubmit-tests-sdk-unit.sh, presubmit-tests-sdk-client.sh) to pre-install kfp-server-api from local source (backend/api/v2beta1/python_http_client).
  • This ensures pip satisfies dependency constraints using local artifacts instead of hitting PyPI.
  • Shortened internal comments for better scannability.

fixes #12906

Copilot AI review requested due to automatic review settings February 27, 2026 14:47
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nsingla for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🎉 Welcome to the Kubeflow Pipelines repo! 🎉

Thanks for opening your first PR! We're excited to have you onboard 🚀

Next steps:

Feel free to ask questions in the comments.

@google-oss-prow
Copy link

Hi @rishabh998186. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI failure that occurs during version bumps when the KFP SDK references a version of kfp-server-api that hasn't been published to PyPI yet. The issue manifested in regression tests that use Docker containers, where pip would fail to resolve the unreleased kfp-server-api dependency.

Changes:

  • Build and use local kfp wheel for regression tests instead of git URL to avoid PyPI dependency resolution
  • Pre-install kfp-server-api from local source in all SDK test scripts before installing the main SDK package
  • Add python build module to test dependencies

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/presubmit-tests-sdk.sh Added build module installation, local kfp-server-api installation, and local wheel building logic to replace git URL-based KFP_PACKAGE_PATH
test/presubmit-tests-sdk-unit.sh Added local kfp-server-api installation before SDK installation
test/presubmit-tests-sdk-client.sh Added local kfp-server-api installation before SDK installation

Signed-off-by: rishabh998186 <rishabh998186@gmail.com.com>
@rishabh998186 rishabh998186 force-pushed the fix/sdk-tests-use-local-wheel-12906 branch from 7086f16 to d61ae8d Compare February 27, 2026 15:23
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Feb 27, 2026
@rishabh998186
Copy link
Contributor Author

@droctothorpe ,
Could you please look at my pr when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] local SDK tests not looking for package on pypi

2 participants