-
Notifications
You must be signed in to change notification settings - Fork 2k
docs(backend): add backend component overview section #12871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RATNAPRADEEP
wants to merge
6
commits into
kubeflow:master
Choose a base branch
from
RATNAPRADEEP:docs-backend-overview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac30a2f
docs(backend): add backend component overview section
RATNAPRADEEP 01bd9f3
Merge branch 'master' into docs-backend-overview
RATNAPRADEEP d3fb0a0
docs: add Scheduled Workflow Controller and Viewer Controller to back…
RATNAPRADEEP 6df9265
fix: update driver description as per review
RATNAPRADEEP 8f7d265
Merge branch 'master' into docs-backend-overview
RATNAPRADEEP 624e43e
Merge branch 'master' into docs-backend-overview
RATNAPRADEEP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Driver description as "Translates pipeline specifications into executable workflow definitions" may be imprecise. Based on the code in
backend/src/v2/driver/driver.goandbackend/src/v2/cmd/driver/main.go, the driver appears to be responsible for orchestrating task execution (ROOT_DAG, DAG, CONTAINER types) and managing execution state with MLMD, rather than translating specifications.The pipeline-to-workflow translation is typically done by the compiler component. Consider revising this description to something more accurate like "Orchestrates task execution and manages execution state" or "Prepares and manages the execution context for pipeline tasks".