Skip to content

fix: hide workspace kind pod labels in summary#1154

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:notebooks-v2from
yanmo42:platypus/kubeflow-1143-hide-kind-pod-labels
Jun 17, 2026
Merged

fix: hide workspace kind pod labels in summary#1154
google-oss-prow[bot] merged 1 commit into
kubeflow:notebooks-v2from
yanmo42:platypus/kubeflow-1143-hide-kind-pod-labels

Conversation

@yanmo42

@yanmo42 yanmo42 commented Jun 4, 2026

Copy link
Copy Markdown

Fixes #1143.

Summary

  • stop showing WorkspaceKind pod metadata labels in the create-flow summary panel
  • keep image and pod config option labels visible in their summary cards
  • add a focused unit test for the summary panel behavior

Tests

  • npm run test:jest -- WorkspaceFormSummaryPanel.spec.tsx --runInBand
  • npx prettier --check src/app/pages/Workspaces/Form/WorkspaceFormSummaryPanel.tsx src/app/pages/Workspaces/Form/tests/WorkspaceFormSummaryPanel.spec.tsx
  • npm run test:lint -- --quiet --ext .tsx src/app/pages/Workspaces/Form/WorkspaceFormSummaryPanel.tsx src/app/pages/Workspaces/Form/tests/WorkspaceFormSummaryPanel.spec.tsx
  • git diff --check

AI Tooling Disclosure

AI tooling was used in developing this contribution. I reviewed, tested, and take full responsibility for the changes.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Kubeflow Notebooks Jun 4, 2026
@google-oss-prow google-oss-prow Bot added the area/frontend area - related to frontend components label Jun 4, 2026
@google-oss-prow google-oss-prow Bot requested review from caponetto and thaorell June 4, 2026 02:56
@google-oss-prow google-oss-prow Bot added area/v2 area - version - kubeflow notebooks v2 size/M labels Jun 4, 2026
@yanmo42

yanmo42 commented Jun 5, 2026

Copy link
Copy Markdown
Author

/cc @thaorell @caponetto

@thaorell thaorell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@paulovmr

paulovmr commented Jun 9, 2026

Copy link
Copy Markdown

/ok-to-test

@paulovmr

paulovmr commented Jun 9, 2026

Copy link
Copy Markdown

Hi @yanmo42 , could you please rebase this PR? Thanks!

@thaorell

thaorell commented Jun 9, 2026

Copy link
Copy Markdown

@yanmo42 can you include some screenshots of the before and after as well? thanks

@andyatmiami

Copy link
Copy Markdown
Contributor

/retest

@christian-heusel

Copy link
Copy Markdown
Member

/test all

@google-oss-prow

Copy link
Copy Markdown

@christian-heusel: No presubmit jobs available for kubeflow/notebooks@notebooks-v2

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christian-heusel

christian-heusel commented Jun 9, 2026

Copy link
Copy Markdown
Member

@paulovmr @andyatmiami as discussed in the meeting I have looked into the issue about the tests not running despite the MR having "ok-to-test" set and it seems like the problem is that there are just no action_required runs for this branch (not that the action is not approving them):

$ gh api "repos/kubeflow/notebooks/actions/runs?event=pull_request&status=action_required&head_sha=848d2d8508b0f09395f8cd129ab02d41a08cb4c0" \
  --jq '.workflow_runs[] | {name, status, conclusion, created_at, id}'
<no output>

This seems to be due to a transient Github issue, as other branches (in this case #1167) have pending runs, so it should be resolve once @yanmo42 rebases the branch as requested 🤗

$ gh api "repos/kubeflow/notebooks/actions/runs?event=pull_request&status=action_required&head_sha=dfe22c9960f435cd279e74f27199e794bc6145b6" \
  --jq '.workflow_runs[] | {name, status, conclusion, created_at, id}'
{
  "conclusion": "action_required",
  "created_at": "2026-06-07T16:04:17Z",
  "id": 27097671334,
  "name": "E2E Tests",
  "status": "completed"
}
{
  "conclusion": "action_required",
  "created_at": "2026-06-07T16:04:17Z",
  "id": 27097671364,
  "name": "Controller - Build and Test",
  "status": "completed"
}
{
  "conclusion": "action_required",
  "created_at": "2026-06-07T16:04:17Z",
  "id": 27097671405,
  "name": "Backend - Build and Test",
  "status": "completed"
}

@andyatmiami

Copy link
Copy Markdown
Contributor

@yanmo42 - if you can rebase this PR on latest notebooks-v2 branch and push.. to hopefully trigger tests...

we can then get this merged..

Signed-off-by: Ian Moog <ianmoog42@gmail.com>
@yanmo42 yanmo42 force-pushed the platypus/kubeflow-1143-hide-kind-pod-labels branch from 848d2d8 to afb106a Compare June 17, 2026 17:02
@google-oss-prow google-oss-prow Bot removed the lgtm label Jun 17, 2026
@yanmo42

yanmo42 commented Jun 17, 2026

Copy link
Copy Markdown
Author

Done — rebased onto latest notebooks-v2 (now at 594bff9). Should trigger tests now. Thanks for the nudge!

@andyatmiami

Copy link
Copy Markdown
Contributor

@paulovmr - checks did run now - can you re-review as time allows as we should be able to get this one in!

@paulovmr paulovmr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit ad67869 into kubeflow:notebooks-v2 Jun 17, 2026
8 of 9 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Kubeflow Notebooks Jun 17, 2026
@yanmo42 yanmo42 deleted the platypus/kubeflow-1143-hide-kind-pod-labels branch June 18, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/M

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants