fix: hide workspace kind pod labels in summary#1154
Conversation
|
/cc @thaorell @caponetto |
|
/ok-to-test |
|
Hi @yanmo42 , could you please rebase this PR? Thanks! |
|
@yanmo42 can you include some screenshots of the before and after as well? thanks |
|
/retest |
|
/test all |
|
@christian-heusel: No presubmit jobs available for kubeflow/notebooks@notebooks-v2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@paulovmr @andyatmiami as discussed in the meeting I have looked into the issue about the tests not running despite the MR having "ok-to-test" set and it seems like the problem is that there are just no This seems to be due to a transient Github issue, as other branches (in this case #1167) have pending runs, so it should be resolve once @yanmo42 rebases the branch as requested 🤗 |
|
@yanmo42 - if you can rebase this PR on latest we can then get this merged.. |
Signed-off-by: Ian Moog <ianmoog42@gmail.com>
848d2d8 to
afb106a
Compare
|
Done — rebased onto latest |
|
@paulovmr - checks did run now - can you re-review as time allows as we should be able to get this one in! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ad67869
into
kubeflow:notebooks-v2
Fixes #1143.
Summary
Tests
AI Tooling Disclosure
AI tooling was used in developing this contribution. I reviewed, tested, and take full responsibility for the changes.