changed selector icon and updated mod-arch packages#2286
changed selector icon and updated mod-arch packages#2286google-oss-prow[bot] merged 2 commits intokubeflow:mainfrom
Conversation
f8c9197 to
1977740
Compare
manaswinidas
left a comment
There was a problem hiding this comment.
I'll defer to @jenny-s51 about the version numbers otherwise looks good.
jenny-s51
left a comment
There was a problem hiding this comment.
I'll defer to @jenny-s51 about the version numbers otherwise looks good.
@manaswinidas appreciate the tag here! The icons are looking really great @rsun19.
I'd recommend targeting ~1.6.0 instead of ~1.8.2 for now as there is a known bug with the FileUpload component in the MUI theme and we do have an instance of FileUpload in the MR UI. Once opendatahub-io/mod-arch-library#134 is fixed we can do a subsequent bump to pick up the full 1.8.x improvements. WDYT @rsun19?
|
@jenny-s51 I'd rather just wait for your PR to merge and the new release to start. The point of the PR was to merge my changes to the icon, which did not get in until yesterday |
| @@ -149,7 +151,7 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({ | |||
| <Flex spaceItems={{ default: 'spaceItemsSm' }} alignItems={{ default: 'alignItemsCenter' }}> | |||
| <FlexItem> | |||
| <Icon> | |||
There was a problem hiding this comment.
| <Icon> | |
| <Icon iconSize="xl" isInline> |
| @@ -149,7 +151,7 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({ | |||
| <Flex spaceItems={{ default: 'spaceItemsSm' }} alignItems={{ default: 'alignItemsCenter' }}> | |||
| <FlexItem> | |||
| <BlueprintIcon /> | ||
| <TypedObjectIcon resourceType={ProjectObjectType.modelRegistryNavigator} /> | ||
| </Icon> | ||
| </FlexItem> |
Signed-off-by: rsun19 <robertssun1234@gmail.com>
Signed-off-by: rsun19 <robertssun1234@gmail.com>
b74fb2e to
bd57365
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jenny-s51
left a comment
There was a problem hiding this comment.
Thank you @rsun19 - icon changes look great.
When you have a moment @lucferbux, since this is out of scope here, can you help us merge opendatahub-io/mod-arch-library#144 as a follow-up? It has the fix for the file upload bug in the shared library and will require some additional changes in MR to fix.


Description
Changed the selector icon in the Model Registry page and updated the
mod-archpackagesHow Has This Been Tested?
Manual testing
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes