Skip to content

changed selector icon and updated mod-arch packages#2286

Merged
google-oss-prow[bot] merged 2 commits intokubeflow:mainfrom
rsun19:change-icon-update-mod-arch
Mar 2, 2026
Merged

changed selector icon and updated mod-arch packages#2286
google-oss-prow[bot] merged 2 commits intokubeflow:mainfrom
rsun19:change-icon-update-mod-arch

Conversation

@rsun19
Copy link
Contributor

@rsun19 rsun19 commented Feb 26, 2026

Description

Changed the selector icon in the Model Registry page and updated the mod-arch packages

Screenshot 2026-02-26 at 4 45 09 PM

How Has This Been Tested?

Manual testing

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @jenny-s51 about the version numbers otherwise looks good.

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @jenny-s51 about the version numbers otherwise looks good.

@manaswinidas appreciate the tag here! The icons are looking really great @rsun19.

I'd recommend targeting ~1.6.0 instead of ~1.8.2 for now as there is a known bug with the FileUpload component in the MUI theme and we do have an instance of FileUpload in the MR UI. Once opendatahub-io/mod-arch-library#134 is fixed we can do a subsequent bump to pick up the full 1.8.x improvements. WDYT @rsun19?

@rsun19 rsun19 changed the title changed selector icon and updated mod-arch packages [wip]changed selector icon and updated mod-arch packages Feb 27, 2026
@rsun19 rsun19 changed the title [wip]changed selector icon and updated mod-arch packages [wip] changed selector icon and updated mod-arch packages Feb 27, 2026
@rsun19
Copy link
Contributor Author

rsun19 commented Feb 27, 2026

@jenny-s51 I'd rather just wait for your PR to merge and the new release to start. The point of the PR was to merge my changes to the icon, which did not get in until yesterday

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some code suggestions below to fix the issue flagged by @jgiardino

Before:
Image

After:
Image

@@ -149,7 +151,7 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({
<Flex spaceItems={{ default: 'spaceItemsSm' }} alignItems={{ default: 'alignItemsCenter' }}>
<FlexItem>
<Icon>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Icon>
<Icon iconSize="xl" isInline>

@@ -149,7 +151,7 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({
<Flex spaceItems={{ default: 'spaceItemsSm' }} alignItems={{ default: 'alignItemsCenter' }}>
<FlexItem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<FlexItem>

<BlueprintIcon />
<TypedObjectIcon resourceType={ProjectObjectType.modelRegistryNavigator} />
</Icon>
</FlexItem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</FlexItem>

Signed-off-by: rsun19 <robertssun1234@gmail.com>
Signed-off-by: rsun19 <robertssun1234@gmail.com>
@rsun19 rsun19 force-pushed the change-icon-update-mod-arch branch from b74fb2e to bd57365 Compare February 27, 2026 20:48
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rsun19 - icon changes look great.

When you have a moment @lucferbux, since this is out of scope here, can you help us merge opendatahub-io/mod-arch-library#144 as a follow-up? It has the fix for the file upload bug in the shared library and will require some additional changes in MR to fix.

@rsun19 rsun19 changed the title [wip] changed selector icon and updated mod-arch packages changed selector icon and updated mod-arch packages Mar 2, 2026
@google-oss-prow google-oss-prow bot merged commit 41b06e4 into kubeflow:main Mar 2, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants