chore: make csi and controller commands into sub-modules#2285
Draft
pboyd wants to merge 1 commit intokubeflow:mainfrom
Draft
chore: make csi and controller commands into sub-modules#2285pboyd wants to merge 1 commit intokubeflow:mainfrom
pboyd wants to merge 1 commit intokubeflow:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/cc @Al-Pragliola |
e5d0923 to
4ae834f
Compare
Signed-off-by: Paul Boyd <paul@pboyd.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the controller and csi packages into submodules so we can remove their dependencies from the root module.
This reverses the changes from #601 (for issue #308). The problem back then was that when a dependency of model-registry was updated there would also have to be a corresponding upgrade in
csi. But that probably could have been solved with areplacedirective in go.mod (see here, it imported model-registry at a specific version without areplace). And secondly, it only needs the generated openapi client which has been it's own package for a while now (without any dependencies), so csi and controller won't actually be importing model-registry itself.How Has This Been Tested?
Built the images locally and ran tests.
Merge criteria:
DCOcheck)