Skip to content

chore: make csi and controller commands into sub-modules#2285

Draft
pboyd wants to merge 1 commit intokubeflow:mainfrom
pboyd:submodules
Draft

chore: make csi and controller commands into sub-modules#2285
pboyd wants to merge 1 commit intokubeflow:mainfrom
pboyd:submodules

Conversation

@pboyd
Copy link
Member

@pboyd pboyd commented Feb 26, 2026

Description

Make the controller and csi packages into submodules so we can remove their dependencies from the root module.

This reverses the changes from #601 (for issue #308). The problem back then was that when a dependency of model-registry was updated there would also have to be a corresponding upgrade in csi. But that probably could have been solved with a replace directive in go.mod (see here, it imported model-registry at a specific version without a replace). And secondly, it only needs the generated openapi client which has been it's own package for a while now (without any dependencies), so csi and controller won't actually be importing model-registry itself.

How Has This Been Tested?

Built the images locally and ran tests.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pboyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pboyd
Copy link
Member Author

pboyd commented Feb 26, 2026

/cc @Al-Pragliola

@pboyd pboyd force-pushed the submodules branch 2 times, most recently from e5d0923 to 4ae834f Compare March 2, 2026 13:11
Signed-off-by: Paul Boyd <paul@pboyd.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant