Add endpoint, types and API hooks for MCP server catalog#2277
Open
ppadti wants to merge 3 commits intokubeflow:mainfrom
Open
Add endpoint, types and API hooks for MCP server catalog#2277ppadti wants to merge 3 commits intokubeflow:mainfrom
ppadti wants to merge 3 commits intokubeflow:mainfrom
Conversation
Signed-off-by: ppadti <ppadti@redhat.com>
Signed-off-by: ppadti <ppadti@redhat.com>
Signed-off-by: ppadti <ppadti@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add endpoint, types, mocks and api hooks for mcp server catalog.
Need to add unit test for hooks - will be done in follow-up PR.
How Has This Been Tested?
run the application in mock mode and try this curl commands:
List MCP servers
curl -s -H "kubeflow-userid: user@example.com" \ "http://localhost:4000/api/v1/model_catalog/mcp_servers?namespace=kubeflow"MCP filter options
curl -s -H "kubeflow-userid: user@example.com" \ "http://localhost:4000/api/v1/model_catalog/mcp_servers_filter_options?namespace=kubeflow"Get a MCP server
curl -s -H "kubeflow-userid: user@example.com" \ "http://localhost:4000/api/v1/model_catalog/mcp_servers/prometheus-mcp?namespace=kubeflow"MCP server tools
curl -s -H "kubeflow-userid: user@example.com" \ "http://localhost:4000/api/v1/model_catalog/mcp_servers/prometheus-mcp/tools?namespace=kubeflow"modified source endpoint
curl -s "http://localhost:4000/api/v1/model_catalog/sources?namespace=kubeflow&assetType=models" -H "kubeflow-userid: [user@example.com](mailto:user@example.com)"curl -s "http://localhost:4000/api/v1/model_catalog/sources?namespace=kubeflow&assetType=mcp_servers" -H "kubeflow-userid: [user@example.com](mailto:user@example.com)"Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes