Skip to content

Conversation

@vanviegen
Copy link

Added a benchmark for https://aberdeenjs.org/

Is this (just including the prebuilt js file for the lib, like keyed/alpine does) an okay way to do it?

Thanks for taking the time!

@krausest
Copy link
Owner

aberdeen.js is currently not included in the PR.
I'd really prefer to use npm to install the libs. This allows me to update implementations and to track how old the libs are.
Can you update the PR to install via npm?

@vanviegen
Copy link
Author

@krausest, oops! The .gitignore for dist got me.

I've now added the library as an npm dependency, and added a build step.

@krausest
Copy link
Owner

Thanks - it builds now fine, but my check (npm run isKeyed keyed/aberdeen)complains it's not really keyed:

Keyed test for swap failed. Swap must add the TRs that it removed, but there were 2 new nodes
Keyed test for create rows failed. Expected that 1000 TRs should be removed and added, but there were 0 added TRs and 0 were removed
aberdeen-v1.0.4-keyed is non-keyed for 'run benchmark' and keyed for 'remove row benchmark' and non-keyed for 'swap rows benchmark' . It'll appear as non-keyed in the results
ERROR: Framework aberdeen-v1.0.4-keyed is not correctly categorized

Can you take a look at it please?

@vanviegen
Copy link
Author

Based on your description it seemed to me that Aberdeen doesn't fit in either category, but keyed seemed closer.

As there doesn't appear to be anything like npm run isNonKeyed, I guess that bucket can be used for 'misc'? I've moved the directory in my pull request.

Sorry for my slow response!

@krausest krausest merged commit 409d9ef into krausest:master Jun 19, 2025
@krausest
Copy link
Owner

There were no non-keyed results for chrome 137, so I can't offer you a comparison yet, but here are the figures:
aberdeen

@vanviegen
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants