fix: pass event to callback instead of nil when file changes detected#384
Merged
knadh merged 4 commits intoknadh:masterfrom Dec 19, 2025
Merged
fix: pass event to callback instead of nil when file changes detected#384knadh merged 4 commits intoknadh:masterfrom
knadh merged 4 commits intoknadh:masterfrom
Conversation
Owner
|
Looks good @josepdcs. Once you've test and confirm, we can merge. |
Contributor
Author
|
Hi @knadh |
Collaborator
|
LGTM 👍 |
Owner
|
Released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted fix to the file watching logic in the
providers/file/file.gofile. The change ensures that the callback function receives the actual file system event object rather thannil, which allows consumers of the API to have more context about the event that triggered the callback.File watching improvement:
Watchmethod inFileto pass the actualeventobject to the callback instead ofnil, providing more context to callback consumers.