Skip to content

Conversation

@EmilienSanterre
Copy link
Contributor

icon-dropdown actions could use a field "labelParam" in order to enable parametrized message

Description

I want to be able to give a second argument to translate the label of one of the actions

Example [in case of a new feature]

<Dropdown operationList={[
                    {
                        label: 'something.parameterizedMessage',
                        labelParam: {param1: 'thing', param2: 'stuff'},
                        action: () => {
                            this.setState({
                                displayPopin: true
                            });
                        }
                    }
                ]}
                    buttonType='button'
                />```

@JohnnP JohnnP added this to the 2.2.0 milestone Jul 7, 2017
@Hartorn Hartorn self-assigned this Jul 17, 2017
@Hartorn Hartorn self-requested a review July 17, 2017 22:08
Copy link
Contributor

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea, but this need to be more generalized

@Hartorn
Copy link
Contributor

Hartorn commented Jul 17, 2017

@c3dr0x @JohnnP Any Idea how we could generalize that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants