Stop tika-acceptance container when stopping the acceptance backend#78
Merged
Conversation
`make acceptance-backend-dev-start` ran `docker compose up backend-acceptance solr-acceptance`, pulling in tika-acceptance only as a solr-acceptance dependency. docker compose up stops the services it was given on Ctrl-C but leaves such dependencies running, orphaning the tika container. Name tika-acceptance explicitly in the up command so it is stopped too.
The acceptance CI run is driven entirely by Makefile targets (ci-images-load, ci-containers-start, ci-test), but the acceptance paths-filter did not include the root Makefile, so Makefile-only changes that affect how the acceptance stack is built/started/tested did not trigger the acceptance jobs. Add 'Makefile' to the acceptance filter.
Member
Author
|
@davisagli kitconcept.solr runs the solr servers for the cypress tests in a slightly different way than kitconcept.intranet, but just like kitconcept.intranet, it also failed to stop tika in devmode, leaving a stray container running. This is what this PR fixes. |
davisagli
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make acceptance-backend-dev-startleft thetika-acceptancecontainer running after the acceptance stack was stopped.The target ran:
tika-acceptanceonly came up as adepends_ondependency ofsolr-acceptance. On Ctrl-C,docker compose upstops the services it was explicitly given (backend-acceptance, solr-acceptance) but leaves such dependencies running — so tika was orphaned.Fix
Name
tika-acceptanceexplicitly in theupcommand so compose attaches to it and tears it down together with the rest on Ctrl-C.Verification
Reproduced deterministically (even a single Ctrl-C): with only
solr-acceptancenamed,solr-acceptancestops buttika-acceptancestaysUp. Withtika-acceptancenamed as well, a single Ctrl-C stops both.