Hide empty search tabs container on empty search term#74
Merged
Conversation
reekitconcept
force-pushed
the
hide-empty-search-tabs
branch
from
6e2bba4 to
03e1008
Compare
Member
Author
|
@davisagli no urgency to review this - I fixed this directly on kitconcept.intranet, eventually we can merge this and then the local fix can be removed from there when it catches up the new version. |
davisagli
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the search results page, entering an empty search term left a stray grey rectangle where the search tabs (
.searchTabs) normally appear.Cause
With an empty search term there are no facet groups, so
SearchTabsrenders an empty container. Semantic UI's.ui.menuenforces amin-height, so the empty element still paints as a grey box.Fix
Collapse the container in its empty state with
.searchTabs.ui.tabular.menu:empty { display: none; }insolrsearch.less.