Conversation
Extend `utils.scripts.create_site` to accept a list of browser-layer interfaces via `package_iface` and to install additional Generic Setup profiles on newly created sites. Refactor the `create_site.py` script to resolve answers through the shared OPTIONS/env-var mechanism, refresh the test answers to kitconcept core defaults, and add an end-to-end `create_site` test. Docstrings across the module were rewritten in reStructuredText. Refs: https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/441
sneridagh
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to
utils.scripts.create_siteImplements the two requests from issue #441:
package_ifacenow accepts a list of interfaces —create_sitetakes either a single browser-layer interface or a sequence of them, normalised internally into a tuple applied to the request.additional_profilesargument installs extra GS profiles on newly created sites (via the new_install_additional_profileshelper).Also in this PR
create_site.pyscript to resolve answers through the sharedOPTIONS/ environment-variable mechanism instead of a hard-codedANSWERSdict.default.jsonto kitconcept-core defaults.utils.scriptsin reStructuredText.create_sitetest (TestCreateSite) plus expandedparse_answersparametrisation.Testing
make test— 274 passedruff format+ruff check— clean