Skip to content

Conversation

@doubleJazzCat
Copy link

The AttackPMKID.run() method was not returning the result of run_hashcat() or run_aircrack(). This caused the main attack loop (AttackAll) to receive None instead of True when a PMKID was successfully cracked.

As a result:

  1. The attack loop continued to the next step (WPA handshake capture) unnecessarily.
  2. If the subsequent WPA capture failed, the target was marked as failed.
  3. The successfully cracked PMKID password was never saved to cracked.json because the success flag was lost.

This commit adds the missing return statements to ensure the success status is propagated correctly, allowing Wifite to save the cracked key and stop attacking the target immediately.

The AttackPMKID.run() method was not returning the result of run_hashcat() or run_aircrack(). 
This caused the main attack loop (AttackAll) to receive None instead of True when a PMKID was successfully cracked.

As a result:
1. The attack loop continued to the next step (WPA handshake capture) unnecessarily.
2. If the subsequent WPA capture failed, the target was marked as failed.
3. The successfully cracked PMKID password was never saved to cracked.json because the success flag was lost.

This commit adds the missing return statements to ensure the success status is propagated correctly, allowing Wifite to save the cracked key and stop attacking the target immediately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant