Skip to content

Wrong comparison operator #197

Open
Open
@aalmuqahwi

Description

@aalmuqahwi

using CompanyName.MyMeetings.BuildingBlocks.Domain;
namespace CompanyName.MyMeetings.Modules.Meetings.Domain.Meetings.Rules
{
public class MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule : IBusinessRule
{
private readonly int? _attendeesLimit;
private readonly int _guestsLimit;
public MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule(int? attendeesLimit, int guestsLimit)
{
_attendeesLimit = attendeesLimit;
_guestsLimit = guestsLimit;
}
public bool IsBroken() => _attendeesLimit.HasValue && _attendeesLimit.Value < _guestsLimit;
public string Message => "Attendees limit must be greater than guests limit";
}
}

I believe the comparison operator used in the IsBroken method is wrong because the rule is checking that meeting attendees limit must be greater than guests limit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions