bpf: Specify access type of bpf_sysctl_get_name args #9159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: cd7312a |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7801208 to
a994d4a
Compare
Author
|
Upstream branch: e30329b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/966731=>bpf-next
branch
from
8627040 to
b72fa4f
Compare
Author
|
Upstream branch: e30329b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/966731=>bpf-next
branch
from
b72fa4f to
f88ccc3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a994d4a to
e7d5deb
Compare
Author
|
Upstream branch: 99fe8af |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/966731=>bpf-next
branch
from
f88ccc3 to
5993958
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e7d5deb to
1c12ad1
Compare
Author
|
Upstream branch: c11f34e |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/966731=>bpf-next
branch
from
5993958 to
e2f86c3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
1c12ad1 to
4b5a6fc
Compare
Author
|
Upstream branch: 3ce7cdd |
The second argument of bpf_sysctl_get_name() helper is a pointer to a buffer that is being written to. However that isn't specify in the prototype. Until commit 37cce22 ("bpf: verifier: Refactor helper access type tracking"), all helper accesses were considered as a possible write access by the verifier, so no big harm was done. However, since then, the verifier might make wrong asssumption about the content of that address which might lead it to make faulty optimizations (such as removing code that was wrongly labeled dead). This is what happens in test_sysctl selftest to the tests related to sysctl_get_name. Add MEM_WRITE flag the second argument of bpf_sysctl_get_name(). Signed-off-by: Jerome Marchand <[email protected]> Acked-by: Yonghong Song <[email protected]>
Convert test_sysctl test to prog_tests with minimal change to the tests themselves. Signed-off-by: Jerome Marchand <[email protected]> Acked-by: Yonghong Song <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/966731=>bpf-next
branch
from
e2f86c3 to
aedac85
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=973851 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Specify access type of bpf_sysctl_get_name args
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=973851