This repository was archived by the owner on Nov 22, 2021. It is now read-only.
[pull request] .zip downloaden van een fotoalbum - #43
Open
aykevl wants to merge 34 commits into
Open
Conversation
This array may be removed in the future.
Extracted the code and put it in a separate file 'media.php', resulting in a *much* cleaner design.
Warning: when updating, these should also be applied to config.php. Otherwise, knfotos won't work (it will display a warning).
Only tested in IE9 in IE7/8 mode. But I think it should work. It uses an <object type="video/mp4"/> tag, so any plugin should work (QuickTime is most likely).
Only tested in IE9 in IE7/8 mode. But I think it should work. It uses an <object type="video/mp4"/> tag, so any plugin should work (QuickTime is most likely).
Locks may not always be released when PHP runs from a webserver when there is an error. When run from the CLI (which is the case here), locks are always removed when the process exits: http://stackoverflow.com/questions/12651068/release-of-flock-in-case-of-errors
This because: 1. It makes it more clear that the formats are video resolutions, not photo resolutions. 2. It adds information about which video formats are transcoded.
Conflicts: updatedb.php
Member
|
@Jille ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix voor issue #27