-
-
Notifications
You must be signed in to change notification settings - Fork 145
BE: Impl a default timeout for http requests #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi o-afanasenko! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
@o-afanasenko Would you mind moving this into the config? |
@germanosin ok, I will do tomorrow. |
Thanks in advance! I truly appreciate your contribution! |
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
No feedback received within 7 days. Auto closing. |
@o-afanasenko hmu if you wish to reopen |
…figurate in properties
@Haarolean Could you reopen please? Or is it better to re-create pull request? I pushed to my branch some changes |
…figurate in properties
This is a good change. What is blocking merging it? |
@yeikel make sense, let's merge it. |
What changes did you make? (Give an overview)
Added default timeout to HttpClient because without it some requests can never end, especially for high-load kafka connect.
For us this fixed problem when Kafka connectors page was infinitely in a loading state. Root cause is a kafka connect instance with Debezium connectors which sometimes doesn't respond. But this shouldn't block viewing of other connectors.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)