FE: Add Search Functionality to ACLs page #636
Conversation
kapybro
bot
added
status/triage
|
Hi @Haarolean, just following up on my pull request to see if there are any updates or feedback. :) |
|
can confirm that the principal search is working: but it's still not enough) |
|
Thanks dude! Why not enough? I believe limiting the search to 'principal name' makes sense for the intended use cases, such as quickly verifying whether a specific user is authorized or diagnosing authorization issues tied to a particular principal. Once filtered by principal name, users can further refine results by sorting by operation, for example. We’ve successfully deployed this functionality across hundreds of our clusters, and the feedback from clients has been extremely positive. |
|
@polegkashti kafka/strimzi admin can already easily check acl by manifests for example. |
|
I don't mind expanding the search further, but we can do this in a separate issue, after a thorough analysis. @fallen-up would you mind raising a new issue describing the functionality you're interested in? |
Haarolean
added
scope/frontend
|
@polegkashti thanks for attaching the gif :) |
|
@Haarolean Thanks for your approval. I appricate your work! |
| @@ -36,6 +41,11 @@ const ACList: React.FC = () => { | |||
| } = useBoolean(); | |||
| const [rowId, setRowId] = React.useState(''); | |||
|
|
|||
| // Set the search params to the url based on the localStorage value | |||
| useEffect(() => { | |||
| setSearch(searchParams.get('q') || ''); | |||
There was a problem hiding this comment.
could you please elaborate on what's happening here? I don't quite grasp the relation to local storage here
There was a problem hiding this comment.
It seems there may have been a misunderstanding, this piece of code is no longer part of the PR. I've updated the implementation, and removed this comment.
Could you please review the latest changes when you have a moment?
|
Missing this feature too much Any news? |
|
Hey there, I’ve been extremely busy and haven’t had a chance to look at it yet, but I’ll try to get to it as soon as possible. Apologies for the delay! It’s mostly just a matter of making sure the code is well-commented and makes sense. |
polegkashti
force-pushed
the
feature/search_acl
branch
from
2e4cc4c to
7ca2470
Compare
|
Hi there! 👋 I’ve opened this PR to improve our search UX and hopefully to get it merged since it simple and useful feature. Taking a second look at the way the search was implemented, I noticed that each keystroke was updating the URL in a way that interfered with Back/Forward navigation. I’ve changed a bit the logic so that we:
Importantly, the Please let me know if you’d like any tweaks or have questions! 😊 |
No breaking changes.
What changes did you make? (Give an overview)
This PR introduces a search functionality in ACLs page that allows users to search by principal name. This feature was developed to improve the debugging process for users managing clusters with numerous ACLs, especially when clients encounter "authorization failed" errors. And in general this feature enables users to quickly locate specific ACL entries, saving time and making the debugging experience more efficient and user friendly.
Fixes #621
Is there anything you'd like reviewers to focus on?
No. There are not many changes :)
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
This feature has been tested and deployed on production clustres with many acls and it works great :)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A visualization of the new feature:
https://github.com/user-attachments/assets/4b591910-3f4c-401d-9809-fcf9b0b129a0
A picture of a cute animal (not mandatory but encouraged)
