BE: RBAC: Impl default role #1056
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package io.kafbat.ui.model.rbac; | ||
|
|
||
| import static com.google.common.base.Preconditions.checkArgument; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class DefaultRole { | ||
|
|
||
| private List<Permission> permissions = new ArrayList<>(); | ||
|
|
||
| public void validate() { | ||
| permissions.forEach(Permission::validate); | ||
| permissions.forEach(Permission::transform); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,5 +21,4 @@ public void validate() { | |
| permissions.forEach(Permission::transform); | ||
| subjects.forEach(Subject::validate); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| package io.kafbat.ui.service.rbac; | ||
|
|
||
| import static io.kafbat.ui.service.rbac.MockedRbacUtils.DEFAULT_ROLE; | ||
| import static io.kafbat.ui.service.rbac.MockedRbacUtils.PROD_CLUSTER; | ||
| import static io.kafbat.ui.service.rbac.MockedRbacUtils.getAccessContext; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import io.kafbat.ui.AbstractIntegrationTest; | ||
| import io.kafbat.ui.config.auth.RbacUser; | ||
| import io.kafbat.ui.config.auth.RoleBasedAccessControlProperties; | ||
| import io.kafbat.ui.model.ClusterDTO; | ||
| import io.kafbat.ui.model.rbac.AccessContext; | ||
| import io.kafbat.ui.model.rbac.DefaultRole; | ||
| import java.util.List; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockedStatic; | ||
| import org.mockito.Mockito; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.security.core.Authentication; | ||
| import org.springframework.security.core.context.ReactiveSecurityContextHolder; | ||
| import org.springframework.security.core.context.SecurityContext; | ||
| import org.springframework.test.annotation.DirtiesContext; | ||
| import org.springframework.test.util.ReflectionTestUtils; | ||
| import reactor.core.publisher.Mono; | ||
| import reactor.test.StepVerifier; | ||
|
|
||
|
|
||
| /** | ||
| * Test class for AccessControlService with default role and RBAC enabled. | ||
| */ | ||
| @DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS) | ||
| public class AccessControlServiceDefaultRoleRbacEnabledTest extends AbstractIntegrationTest { | ||
|
|
||
| @Autowired | ||
| AccessControlService accessControlService; | ||
|
|
||
| @Mock | ||
| SecurityContext securityContext; | ||
|
|
||
| @Mock | ||
| Authentication authentication; | ||
|
|
||
| @Mock | ||
| RbacUser user; | ||
|
|
||
| @Mock | ||
| DefaultRole defaultRole; | ||
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
|
|
||
| RoleBasedAccessControlProperties properties = mock(); | ||
| defaultRole = MockedRbacUtils.getDefaultRole(); | ||
| when(properties.getDefaultRole()).thenReturn(defaultRole); | ||
| when(properties.getRoles()).thenReturn(List.of()); // Return empty list for roles | ||
|
|
||
|
|
||
| ReflectionTestUtils.setField(accessControlService, "properties", properties); | ||
| ReflectionTestUtils.setField(accessControlService, "rbacEnabled", true); | ||
|
|
||
| // Mock security context | ||
| when(securityContext.getAuthentication()).thenReturn(authentication); | ||
| when(authentication.getPrincipal()).thenReturn(user); | ||
| } | ||
|
|
||
| public void withSecurityContext(Runnable runnable) { | ||
| try (MockedStatic<ReactiveSecurityContextHolder> ctxHolder = Mockito.mockStatic( | ||
| ReactiveSecurityContextHolder.class)) { | ||
| // Mock static method to get security context | ||
| ctxHolder.when(ReactiveSecurityContextHolder::getContext).thenReturn(Mono.just(securityContext)); | ||
| runnable.run(); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| void validateAccess() { | ||
| withSecurityContext(() -> { | ||
| when(user.groups()).thenReturn(List.of(DEFAULT_ROLE)); | ||
|
There was a problem hiding this comment. Not following here, what are we testing here for? Given that we mock users' groups, it seems that no newly implemented logic is gonna be tested against? |
||
| AccessContext context = getAccessContext(PROD_CLUSTER, true); | ||
| Mono<Void> validateAccessMono = accessControlService.validateAccess(context); | ||
| StepVerifier.create(validateAccessMono) | ||
| .expectComplete() | ||
| .verify(); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void isClusterAccessible() { | ||
| withSecurityContext(() -> { | ||
| ClusterDTO clusterDto = new ClusterDTO(); | ||
| clusterDto.setName(PROD_CLUSTER); | ||
| Mono<Boolean> clusterAccessibleMono = accessControlService.isClusterAccessible(clusterDto); | ||
| StepVerifier.create(clusterAccessibleMono) | ||
| .expectNext(true) | ||
| .expectComplete() | ||
| .verify(); | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps an explicit setter is redundant here