Skip to content

FE: Fix blocked public assets (#1038) #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Masqueey
Copy link

@Masqueey Masqueey commented Apr 24, 2025

What changes did you make?
Added all remaining assets in the frontend/public folder to the list of objects that can be viewed unauthenticated. Fixes #1038.
Fixes #1038

Is there anything you'd like reviewers to focus on?
I couldn't figure out how to fix the issue with the logout page, but it is so minor that it can also be ignored. If you have suggestions, let me know and I'll include them in the PR.

How Has This Been Tested?

  • No: please help, see below
  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Why have you not tested your change?
Due to licensing, I can't use docker-desktop but instead use colima. I have tried for the past two hours to get things to work and I can get a build to finish as long as I don't try to build docker images.

I keep getting "Connection refused" when the container tries to connect to localhost. I have ended up on these two seemingly useful comments, but they didn't work for me.

I don't understand Colima or Docker well enough to figure out how to enable the localhost connection. If someone has a way to help me get the environment set up, I'll happily give it a shot and test my own PR.

Otherwise, if you are able to test my PR, please let me know whether it resolved the linked issue. 🙏

Checklist (put an "x" next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)
image

@Masqueey Masqueey requested a review from a team as a code owner April 24, 2025 14:52
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 24, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Masqueey! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@germanosin
Copy link
Member

@Masqueey, thanks for fixing that! I'll also take a look into why these images aren't in the assets directory as they should be.

@Haarolean
Copy link
Member

@Masqueey, thanks for fixing that! I'll also take a look into why these images aren't in the assets directory as they should be.

@germanosin, while at it, could you please also look at how to run the app with Idea's run configuration with static files built? It's been broken since migrating to gradle.

@Haarolean
Copy link
Member

As German mentioned, these static files should be in assets directory altogether, rather than whitelisting different paths. I'll convert this to a draft while it's being investigated.

@Haarolean Haarolean marked this pull request as draft April 25, 2025 04:04
@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress labels May 29, 2025
@germanosin
Copy link
Member

@Masqueey, thanks for fixing that! I'll also take a look into why these images aren't in the assets directory as they should be.

@germanosin, while at it, could you please also look at how to run the app with Idea's run configuration with static files built? It's been broken since migrating to gradle.

this one fixed.
I'll check statics path soon

@germanosin
Copy link
Member

@Masqueey i fixed this issue in the another PR #1109. I think we could close this one

@Masqueey
Copy link
Author

Agreed!

Fixed by #1109.

@Masqueey Masqueey closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing assets on login page
3 participants