-
Notifications
You must be signed in to change notification settings - Fork 75
fix: payload optional processing_account_id validations
#4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
susrithasabbini
wants to merge
8
commits into
main
Choose a base branch
from
fix/payload-connector-non-required-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riddhiagrawal001
previously approved these changes
Jan 23, 2026
VenuMadhav2541
previously approved these changes
Jan 23, 2026
…center into fix/payload-connector-non-required-changes
27a29e4
Riddhiagrawal001
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fix validation logic for multi-currency auth key configuration.
Each currency configuration contains:
api_key(required)processing_account_id(optional)Previously, the Proceed button was enabled even when the request payload was invalid.
For example, if
api_keywas filled in one currency and onlyprocessing_account_id(optional field) was filled in another currency, the button was enabled, which should
not be allowed.
The Proceed button should be enabled only when the request dictionary is valid.
Validation rules
currency must also be filled
across all currencies
Scenarios
Motivation and Context
Fixes: https://github.com/juspay/hyperswitch-cloud/issues/14135
This change ensures that invalid payloads are not allowed to proceed and that
currency-wise validation is enforced correctly.
How did you test it?
Tested locally by validating different combinations of required and optional
fields across multiple currencies.
Screen.Recording.2026-01-22.at.3.50.24.PM.mov
Where to test it?
Checklist
npm run re:build