feat: embeddable bank debit PMT #4108
Merged
+238
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
src/screens/Connectors/PaymentProcessor/ConnectorMetaData/BankDebit/BankDebit.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
susrithasabbini
approved these changes
Jan 23, 2026
susrithasabbini
requested changes
Jan 27, 2026
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorMetaData/BankDebit/BankDebit.res
Outdated
Show resolved
Hide resolved
src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
Outdated
Show resolved
Hide resolved
susrithasabbini
approved these changes
Jan 27, 2026
github-actions
bot
added
the
Closed
Contributor
|
Theres one issue thats happening steps to replicate :
Screen.Recording.2026-01-28.at.12.10.49.PM.mov |
Comment on lines
+592
to
+596
| let handleCheckboxClick = _ => { | ||
| if paymentMethod->getPaymentMethodFromString === BankDebit { | ||
| removeOrAddMethods(value) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can you move this function out
Comment on lines
+578
to
589
| if paymentMethod->getPaymentMethodFromString !== BankDebit { | ||
| removeOrAddMethods(value) | ||
| } | ||
|
|
||
| if showSideModal(value.payment_method_type->getPaymentMethodTypeFromString) { | ||
| if ( | ||
| showAdditionalDetails( | ||
| value.payment_method_type->getPaymentMethodTypeFromString, | ||
| ) | ||
| ) { | ||
| setSelectedWallet(_ => value) | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Can you also move this out
| ("payment_method", paymentMethod->JSON.Encode.string), | ||
| ("payment_method_types", [methodJson]->JSON.Encode.array), | ||
| ] | ||
| ->Dict.fromArray |
| let pmDict = pmJson->getDictFromJsonObject | ||
| let pmMethod = pmDict->getString("payment_method", "")->String.toLowerCase | ||
|
|
||
| if pmMethod === targetMethod { |
Contributor
There was a problem hiding this comment.
Please use type values to check rather than string
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build