Skip to content

Add defaultServiceAccountName option in Helm #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add defaultServiceAccountName option in Helm #1405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/source/operators/deploy-kubernetes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,11 +488,12 @@ can override them with helm's `--set` or `--values` options. Always use `--set`
| `authToken` | Optional authorization token passed in all requests (see --EnterpriseGatewayApp.auth_token) | `nil` |
| `kernel.clusterRole` | Kernel cluster role created by this chart. Used if no KERNEL_NAMESPACE is provided by client. | `kernel-controller` |
| `kernel.shareGatewayNamespace` | Will start kernels in the same namespace as EG if True. | `false` |
| `kernel.defaultServiceAccountName` | Service account name to use for kernel pods when no service account is specified. This service account should exist in the namespace where kernel pods are launched. | `default` |
| `kernel.launchTimeout` | Timeout for kernel launching in seconds. | `60` |
| `kernel.cullIdleTimeout` | Idle timeout in seconds. Default is 1 hour. | `3600` |
| `kernel.cullConnected` | Whether to cull idle kernels that still have clients connected. | `false` |
| `kernel.allowedKernels` | List of kernel names that are available for use. | `{r_kubernetes,...}` (see `values.yaml`) |
| `kernel.defaultKernelName` | Default kernel name should be something from the allowedKernels | `python-kubernetes` |
| `kernel.defaultKernelName` | Default kernel name should be something from the allowedKernels | `python_kubernetes` |
| `kernelspecs.image` | Optional custom data image containing kernelspecs to use. Cannot be used with NFS enabled. | `nil` |
| `kernelspecs.imagePullPolicy` | Kernelspecs image pull policy. | `Always` |
| `nfs.enabled` | Whether NFS-mounted kernelspecs are enabled. Cannot be used with `kernelspecs.image` set. | `false` |
Expand Down
2 changes: 2 additions & 0 deletions etc/kubernetes/helm/enterprise-gateway/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ spec:
value: {{ toJson .Values.kernel.allowedKernels | squote }}
- name: EG_DEFAULT_KERNEL_NAME
value: {{ .Values.kernel.defaultKernelName }}
- name: EG_DEFAULT_KERNEL_SERVICE_ACCOUNT_NAME
value: {{ .Values.kernel.defaultServiceAccountName }}
# Optional authorization token passed in all requests
{{- if .Values.authToken }}
- name: EG_AUTH_TOKEN
Expand Down
3 changes: 3 additions & 0 deletions etc/kubernetes/helm/enterprise-gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ kernel:
- spark_python_operator
# Default kernel name should be something from the allowedKernels
defaultKernelName: python_kubernetes
# Service account name to use for kernel pods when no service account is specified.
# This service account should exist in the namespace where kernel pods are launched.
defaultServiceAccountName: default

kernelspecs:
# Optional custom data image containing kernelspecs to use.
Expand Down
Loading