Quote jsonfield name when selecting in order to account for possible numeric parts in the name#741
Open
ricardogsilva wants to merge 1 commit intojowilf:mainfrom
Conversation
…numeric parts in the name This makes it possible to use JSONField together with ListField
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
===========================================
- Coverage 100.00% 99.72% -0.28%
===========================================
Files 75 86 +11
Lines 5817 6850 +1033
===========================================
+ Hits 5817 6831 +1014
- Misses 0 19 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to the way JSONFieldfields are selected during their respective field initializer function. The change is merely quoting the elemetn's name when finding it with JQuery.
As mentioned in #737, this changes makes it possible to use JSONField together with ListField.