Skip to content

Quote jsonfield name when selecting in order to account for possible numeric parts in the name#741

Open
ricardogsilva wants to merge 1 commit intojowilf:mainfrom
ricardogsilva:737-cannot-use-jsonfield-with-listfield
Open

Quote jsonfield name when selecting in order to account for possible numeric parts in the name#741
ricardogsilva wants to merge 1 commit intojowilf:mainfrom
ricardogsilva:737-cannot-use-jsonfield-with-listfield

Conversation

@ricardogsilva
Copy link
Contributor

This PR makes a small change to the way JSONFieldfields are selected during their respective field initializer function. The change is merely quoting the elemetn's name when finding it with JQuery.

As mentioned in #737, this changes makes it possible to use JSONField together with ListField.


…numeric parts in the name

This makes it possible to use JSONField together with ListField
Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.72%. Comparing base (2540c51) to head (a7bc08a).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #741      +/-   ##
===========================================
- Coverage   100.00%   99.72%   -0.28%     
===========================================
  Files           75       86      +11     
  Lines         5817     6850    +1033     
===========================================
+ Hits          5817     6831    +1014     
- Misses           0       19      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Cannot have multiple JSONField in a ListField

2 participants