Upgrade mcp/sdk to ^0.5, add symfony/finder and symfony/filesystem

[josbeir]

Upgrades mcp/sdk from ^0.4 to ^0.5 and resolves the breaking changes introduced in that release.

Changes

Dependencies (composer.json)

• Bump mcp/sdk to ^0.5
• Add symfony/finder as an explicit dependency — it was a transitive dep via the SDK in 0.4 but was made optional in 0.5
• Add symfony/filesystem for cross-platform path utilities

ServerBuilder::withPluginTools()

• The previous implementation used str_replace(ROOT, '', $pluginSrcPath) to compute a relative scan directory path, which broke silently when the plugin lives outside ROOT (e.g. installed via Composer into a project where ROOT ≠ plugin parent). Replaced with Filesystem::makePathRelative() which correctly computes the relative path in all cases including Windows.

Repository::getMarkdownFiles()

• Replaced RecursiveDirectoryIterator / RecursiveIteratorIterator with symfony/finder's Finder, removing manual path-prefix and separator normalisation logic.

Repository::clone() / DocumentSearchService::__construct()

• Replaced manual is_dir + mkdir + explicit RuntimeException throw with Filesystem::mkdir(), which handles recursive creation and throws on failure itself.

[Copilot]

Pull request overview

This pull request upgrades the MCP PHP SDK to ^0.5 and adapts the plugin to the SDK’s breaking changes by switching to Symfony’s filesystem/path and file-finding utilities for more robust cross-platform behavior.

Changes:

• Bump mcp/sdk to ^0.5 and add explicit symfony/finder + symfony/filesystem dependencies.
• Update tool discovery path handling in ServerBuilder::withPluginTools() to use Filesystem::makePathRelative() instead of str_replace()-based path chopping.
• Replace manual recursive markdown discovery and manual mkdir/rmdir logic with Symfony Finder/Filesystem in documentation components and tests.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
composer.json	Upgrades mcp/sdk and adds Symfony filesystem/finder dependencies.
src/Builder/ServerBuilder.php	Uses Filesystem::makePathRelative() to compute scan directories robustly.
src/Documentation/DocumentSearchService.php	Uses Filesystem::mkdir() for cache DB directory creation.
src/Documentation/Git/Repository.php	Uses Filesystem::mkdir() and Symfony Finder for markdown discovery.
src/Prompts/QualityAssurancePrompt.php	Makes in_array() checks strict (true as 3rd arg).
tests/TestCase/Builder/ServerBuilderTest.php	Updates expectations to match new relative-path computation approach.
tests/TestCase/Documentation/Git/RepositoryTest.php	Uses Symfony Filesystem for test directory setup/cleanup.
tests/TestCase/Prompts/TinkerWorkshopPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/TestingAssistantPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/PerformanceAnalyzerPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/OrmQueryHelperPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/MigrationGuidePromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/FeatureBuilderPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/DocumentationExpertPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/DebugHelperPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/DatabaseExplorerPromptTest.php	Removes redundant local @var annotations in prompt tests.
tests/TestCase/Prompts/CodeReviewerPromptTest.php	Removes redundant local @var annotations in prompt tests.

Comments suppressed due to low confidence (1)

src/Documentation/Git/Repository.php:65

• Filesystem::mkdir() throws Symfony filesystem exceptions (e.g. IOExceptionInterface) rather than RuntimeException. The method docblock promises @throws RuntimeException, so either update the docblock to reflect the new exception type(s) or catch/wrap the filesystem exception to keep the public contract consistent.

     * @throws \RuntimeException If clone fails
     */
    public function clone(): void
    {
        if ($this->exists()) {
            return; // Already cloned
        }

        // Ensure parent directory exists
        (new Filesystem())->mkdir(dirname($this->path));

        // Delegate to git adapter
        $this->gitAdapter->clone($this->url, $this->branch, $this->path);
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.