Skip to content

Fixed docker#477

Open
maqdev wants to merge 8 commits into
jmathai:masterfrom
maqdev:master
Open

Fixed docker#477
maqdev wants to merge 8 commits into
jmathai:masterfrom
maqdev:master

Conversation

@maqdev

@maqdev maqdev commented Apr 24, 2025

Copy link
Copy Markdown

Existing docker doesn't build, so I've fixed and provided small example on how to build and run

@CLAassistant

CLAassistant commented Apr 24, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@webysther

Copy link
Copy Markdown

Will nice in future add also a github action to create the image on ghcr

@Jogai

Jogai commented Oct 17, 2025

Copy link
Copy Markdown

Will nice in future add also a github action to create the image on ghcr

Publishing on ghcr would be nice indeed

@jmathai

jmathai commented Oct 27, 2025

Copy link
Copy Markdown
Owner

I need to understand why the tests are failing - they shouldn't.

@jmathai

jmathai commented Oct 29, 2025

Copy link
Copy Markdown
Owner

I think if you rebase or merge from the master branch here then the tests will pass.

@maqdev

maqdev commented Oct 29, 2025

Copy link
Copy Markdown
Author

I think if you rebase or merge from the master branch here then the tests will pass.

But you just merged it? It says no new commits

Screenshot 2025-10-28 at 18 00 41

@jmathai

jmathai commented Oct 29, 2025

Copy link
Copy Markdown
Owner

But you just merged it? It says no new commits

You're right. I can't seem to get the environment variables exported for the tests. Let me dig a bit more.

@maqdev

maqdev commented Oct 29, 2025

Copy link
Copy Markdown
Author

I suspect its due to pr is from fork? maybe just try and create local branch with the diff

@jmathai jmathai force-pushed the master branch 3 times, most recently from bbdb460 to ec11497 Compare October 29, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants