Fixed docker#477
Open
maqdev wants to merge 8 commits into
Open
Conversation
|
Will nice in future add also a github action to create the image on ghcr |
Publishing on ghcr would be nice indeed |
Owner
|
I need to understand why the tests are failing - they shouldn't. |
Owner
|
I think if you rebase or merge from the master branch here then the tests will pass. |
Author
Owner
You're right. I can't seem to get the environment variables exported for the tests. Let me dig a bit more. |
Author
|
I suspect its due to pr is from fork? maybe just try and create local branch with the diff |
bbdb460 to
ec11497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Existing docker doesn't build, so I've fixed and provided small example on how to build and run