Skip to content

Exposed Feat, Features and most importantly Cmd fields#433

Open
DeadLockStarve wants to merge 1 commit intojlaffaye:masterfrom
DeadLockStarve:master
Open

Exposed Feat, Features and most importantly Cmd fields#433
DeadLockStarve wants to merge 1 commit intojlaffaye:masterfrom
DeadLockStarve:master

Conversation

@DeadLockStarve
Copy link

Not exposing them prevents users from reading supported server features and sending custom server commands (Which are a possibility)
Please review as you wish as long as it respects the purpose of the commit, or at least motivate the rejection

Copy link

@Jonher937 Jonher937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for this PR; I came here as I was looking to expose Cmd myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants