Isolate TagSet copies to prevent shared mutation #2453
Merged
+119
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TagSet copies no longer pull through from the mutable template; they copy existing tags and only use the template’s fallback (the HTML defaults) for lazy lookups. This keeps parser/session tagsets independent and prevents cross-thread mutation that can lead to ConcurrentModificationException. This keeps the use of the HTML default tagset sparse in memory.
Owner
Author
|
Was seeing occasional CI breaks in SessionIT (e.g. https://github.com/jhy/jsoup/actions/runs/20250357192/job/58140769255), this aims to fix those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagSet copies no longer pull through from the mutable template; they copy existing tags and only use the template’s fallback (the HTML defaults) for lazy lookups. This keeps parser/session tagsets independent and prevents cross-thread mutation that can lead to ConcurrentModificationException.
This keeps the use of the HTML default tagset sparse in memory.