Update android-mapviewballoons/src/com/readystatesoftware/mapviewballoon...#19
Open
smannlymann wants to merge 1 commit intojgilfelt:masterfrom
Open
Update android-mapviewballoons/src/com/readystatesoftware/mapviewballoon...#19smannlymann wants to merge 1 commit intojgilfelt:masterfrom
smannlymann wants to merge 1 commit intojgilfelt:masterfrom
Conversation
…oons/BalloonItemizedOverlay.java
Contributor
|
@smannlymann - what effect does this have? |
Author
|
I needed to extend the onTap method. Did you have a particular reason for keeping it final? |
Contributor
|
No, my question was more along the lines of what effect will this have. From my limited Java understanding, this will allow the value returned to be set multiple times rather than (with final) it being set once and for all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...s/BalloonItemizedOverlay.java