[artifactory-ha] Add optional pod management policy#2308
Open
bastirlnd wants to merge 1 commit into
Open
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
2 similar comments
Author
|
recheck |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
Adds (optional) podManagementPolicy to the artifactory-ha charts.
-> Optional to ensure backwards compatibility
Special notes for your reviewer:
We've tested this on our staging environment already and it works like a charm!
Sidenote, I've discovered an issue with the linting process during my contribution steps.
On both master and my branch with its changes the same output appears when running
make lint -- --charts stable/artifactory-haAs this occurs independently to my changes and since my chart change runs in our environment without issues, I have decided to open this PR as well as report the issues with the linting steps!