Skip to content

[artifactory-ha] Add optional pod management policy#2308

Open
bastirlnd wants to merge 1 commit into
jfrog:masterfrom
bastirlnd:br-add-pod-mgmt-policy
Open

[artifactory-ha] Add optional pod management policy#2308
bastirlnd wants to merge 1 commit into
jfrog:masterfrom
bastirlnd:br-add-pod-mgmt-policy

Conversation

@bastirlnd

Copy link
Copy Markdown

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
Adds (optional) podManagementPolicy to the artifactory-ha charts.
-> Optional to ensure backwards compatibility

Special notes for your reviewer:
We've tested this on our staging environment already and it works like a charm!

Sidenote, I've discovered an issue with the linting process during my contribution steps.
On both master and my branch with its changes the same output appears when running make lint -- --charts stable/artifactory-ha

❯ make lint -- --charts stable/artifactory-ha
test/lint-charts.sh
Installing kubeval...
Local run, not downloading kubeval cli...
Installing helm...
Local run, not downloading helm cli...
Error response from daemon: No such container: ct
Linting charts...
Version increment checking disabled.

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 artifactory-ha => (version: "107.146.8", path: "stable/artifactory-ha")
------------------------------------------------------------------------------------------------------------------------

"jfrog" has been added to your repositories
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "jfrog" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://charts.jfrog.io/
Deleting outdated charts
Linting chart 'artifactory-ha => (version: "107.146.8", path: "stable/artifactory-ha")'
Validating /workdir/stable/artifactory-ha/Chart.yaml...
Validation success! 👍

Linting chart with values file 'stable/artifactory-ha/ci/access-tls-values.yaml'...

==> Linting stable/artifactory-ha
[ERROR] templates/: template: artifactory-ha/templates/artifactory-node-statefulset.yaml:1:18: executing "artifactory-ha/templates/artifactory-node-statefulset.yaml" at <.Values.artifactory.node.replicaCount>: nil pointer evaluating interface {}.replicaCount

------------------------------------------------------------------------------------------------------------------------
 ✖︎ artifactory-ha => (version: "107.146.8", path: "stable/artifactory-ha") > Error waiting for process: exit status 1
Error: Error linting charts: Error processing charts
------------------------------------------------------------------------------------------------------------------------
Error linting charts: Error processing charts
make: *** [Makefile:56: lint] Error 1

As this occurs independently to my changes and since my chart change runs in our environment without issues, I have decided to open this PR as well as report the issues with the linting steps!

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bastirlnd

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@bastirlnd

Copy link
Copy Markdown
Author

recheck

2 similar comments
@bastirlnd

Copy link
Copy Markdown
Author

recheck

@bastirlnd

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant