Skip to content

Conversation

@daniel-beck
Copy link
Contributor

Side note: This looks pretty weird due to the very high number of very small stages. It is unclear to me why we're e.g. splitting GPG and code signing cert preparation into separate stages.

@olblak
Copy link
Member

olblak commented Aug 7, 2020

It is unclear to me why we're e.g. splitting GPG and code signing cert preparation into separate stages.
I guess it just a different perception of splitting tasks into multiple stages to be honest I don't really care

Is it really needed to put that when condition for every stages instead of only once at the beginning of the Jenkinsfile?
It would be nice to document this "hack" at least once the first time.

@daniel-beck
Copy link
Contributor Author

Is it really needed to put that when condition for every stages instead of only once at the beginning of the Jenkinsfile?

It would be much easier and cleaner in Scripted Pipeline 🤷

@timja
Copy link
Member

timja commented Aug 8, 2020

Is it really needed to put that when condition for every stages instead of only once at the beginning of the Jenkinsfile?

It would be much easier and cleaner in Scripted Pipeline 🤷

would it be horrible to do?

script {
  if (env.BUILD_NUMBER == "1") {
    return
  }
}

(not sure if that would work)

@daniel-beck
Copy link
Contributor Author

Where would you put that? We need to evaluate the pipeline part because that's where the parameters for subsequent runs are defined.

@timja
Copy link
Member

timja commented Aug 8, 2020

in the first stage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants