Fix HorizonAngle: Include 0° in first quadrant for ray-tracing#474
Open
leleist wants to merge 1 commit intojblindsay:masterfrom
Open
Fix HorizonAngle: Include 0° in first quadrant for ray-tracing#474leleist wants to merge 1 commit intojblindsay:masterfrom
leleist wants to merge 1 commit intojblindsay:masterfrom
Conversation
Previously 0° and 180° produced identical results because 0° was excluded from the first quadrant condition (azimuth > 0). This fix changes the condition to >= 0 so that 0° is correctly handled as north-facing rather than falling through to the second quadrant."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321
Previously 0° and 180° produced identical results because 0° was excluded from the first quadrant condition (azimuth > 0) for ray-tracing. This fix changes the condition to >= 0 so that 0° is correctly handled as north-facing rather than falling through to the second quadrant.
For testing: