Skip to content

Fix Select component styling and remove duplicate Dropdown Icon #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/DataTable/Select.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as React from 'react';
import styled from 'styled-components';
import DropDownIcon from '../icons/Dropdown';

const SelectControl = styled.select`
cursor: pointer;
Expand Down Expand Up @@ -61,7 +60,6 @@ type SelectProps = {
const Select = ({ defaultValue, onChange, ...rest }: SelectProps): JSX.Element => (
<SelectWrapper>
<SelectControl onChange={onChange} defaultValue={defaultValue} {...rest} />
<DropDownIcon />
</SelectWrapper>
);

Expand Down
14 changes: 0 additions & 14 deletions src/DataTable/__tests__/__snapshots__/DataTable.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1425,20 +1425,6 @@ exports[`DataTable::Pagination should change the page position when using pagina
2
</option>
</select>
<svg
height="24"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M7 10l5 5 5-5z"
/>
<path
d="M0 0h24v24H0z"
fill="none"
/>
</svg>
</div>
<span
class="c14 c18"
Expand Down
14 changes: 0 additions & 14 deletions src/DataTable/__tests__/__snapshots__/Pagination.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -170,20 +170,6 @@ exports[`should render correctly with default props 1`] = `
30
</option>
</select>
<svg
height="24"
viewBox="0 0 24 24"
width="24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M7 10l5 5 5-5z"
/>
<path
d="M0 0h24v24H0z"
fill="none"
/>
</svg>
</div>
<span
class="c1 c5"
Expand Down
10 changes: 0 additions & 10 deletions src/icons/Dropdown.tsx

This file was deleted.