Skip to content

Allow custom row container to wrap table row with prefer tag or component #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-data-table-component",
"version": "7.6.2",
"version": "7.6.3",
"description": "A simple to use declarative react based data table",
"main": "dist/index.cjs.js",
"module": "dist/index.es.js",
Expand All @@ -23,6 +23,7 @@
"license": "Apache-2.0",
"prepublish": "tsc",
"scripts": {
"prepare": "npm run build",
"prepublishOnly": "npm run build",
"build:dev": "rollup -c rollup/rollup.config.dev.js -m",
"build:umd": "rollup -c rollup/rollup.config.umd.js",
Expand Down
6 changes: 4 additions & 2 deletions src/DataTable/DataTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ function DataTable<T>(props: TableProps<T>): JSX.Element {
customStyles = defaultProps.customStyles,
direction = defaultProps.direction,
onColumnOrderChange = defaultProps.onColumnOrderChange,
renderRow = defaultProps.renderRow,
className,
} = props;

Expand Down Expand Up @@ -440,7 +441,8 @@ function DataTable<T>(props: TableProps<T>): JSX.Element {
const expanderExpander = !!(expandableRows && expandableRowExpanded && expandableRowExpanded(row));
const expanderDisabled = !!(expandableRows && expandableRowDisabled && expandableRowDisabled(row));

return (
return renderRow(
row,
<Row
id={id}
key={id}
Expand Down Expand Up @@ -484,7 +486,7 @@ function DataTable<T>(props: TableProps<T>): JSX.Element {
onDragEnd={handleDragEnd}
onDragEnter={handleDragEnter}
onDragLeave={handleDragLeave}
/>
/>,
);
})}
</Body>
Expand Down
1 change: 1 addition & 0 deletions src/DataTable/defaultProps.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,5 @@ export const defaultProps = {
onSelectedRowsChange: noop,
onSort: noop,
onColumnOrderChange: noop,
renderRow: <T,>(row: T, rowContent: JSX.Element) => rowContent,
};
1 change: 1 addition & 0 deletions src/DataTable/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ export type TableProps<T> = {
* Shows and displays a header with a title
* */
title?: string | React.ReactNode;
renderRow?: (row: T, rowContent: JSX.Element) => JSX.Element;
};

export type TableColumnBase = {
Expand Down
43 changes: 43 additions & 0 deletions stories/DataTable/RowLink.stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import React from 'react';
import data from '../constants/sampleMovieData';
import DataTable from '../../src/index';

const columns = [
{
name: 'Title',
selector: row => row.title,
sortable: true,
},
{
name: 'Director',
selector: row => row.director,
sortable: true,
},
{
name: 'Year',
selector: row => row.year,
sortable: true,
},
];

export const RowLink = () => {
return (
<DataTable
title="Movie List"
columns={columns}
data={data}
pagination
renderRow={(row, rowContent) => (
<a href={`/${row.id}`} style={{ display: 'block' }} target="_blank" rel="noreferrer">
{rowContent}
</a>
)}
/>
);
};

export default {
title: 'RowLink',
component: RowLink,
parameters: {},
};