Skip to content

Update translation of 3-frames-and-windows/01-popup-windows and etc. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 6, 2020

Conversation

leviding
Copy link
Member

@leviding leviding commented Apr 5, 2020

目标章节:3-frames-and-windows/01-popup-windows

当前上游最新 commitjavascript-tutorial/en.javascript.info@23ffde7

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md javascript-tutorial/en.javascript.info@f9feec2 更新译文

@bemself bemself added 正在校对 WIP Work in process and removed 正在校对 labels Apr 6, 2020
Copy link
Collaborator

@bemself bemself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leviding 校对到一半发现你还没做完哈,先把已经校对过的发出来~


还有一些不太受支持的,浏览器特有的功能。通常不使用这些功能。详情请看 <a href="https://developer.mozilla.org/en/DOM/window.open">window.open in MDN</a>。
还有一些不太受支持的特定于浏览器的功能,通常不使用。特有的功能。通常不使用这些功能。更多示例请见 <a href="https://developer.mozilla.org/en/DOM/window.open">MDN 中的 window.open</a>。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[特有的功能。通常不使用这些功能。] 这句是不是多余了?

原文:
There is also a number of less supported browser-specific features, which are usually not used. Check window.open in MDN for examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对了,漏删了。


```js run
let newWindow = open('/', 'example', 'width=300,height=300')
newWindow.focus();

alert(newWindow.location.href); // (*) about:blank, loading hasn't started yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段注释是不是翻译漏掉了?

@leviding
Copy link
Member Author

leviding commented Apr 6, 2020

@bemself 好嘞,马上完事儿

@leviding leviding removed the WIP Work in process label Apr 6, 2020
@leviding
Copy link
Member Author

leviding commented Apr 6, 2020

@bemself 更新完成啦,可以继续校对啦!

Copy link
Collaborator

@bemself bemself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leviding 👍 👍

@bemself bemself merged commit 1e765e2 into master Apr 6, 2020
@leviding leviding deleted the leviding-patch-1 branch April 6, 2020 06:50
@leviding
Copy link
Member Author

leviding commented Apr 6, 2020

@bemself 谢谢,辛苦啦!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants