Skip to content

Function expressions #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 25, 2022
Merged

Function expressions #82

merged 8 commits into from
Jul 25, 2022

Conversation

otmon76
Copy link
Contributor

@otmon76 otmon76 commented Apr 18, 2022

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Apr 18, 2022
@javascript-translate-bot javascript-translate-bot requested a review from a team April 18, 2022 20:40
@danipoma danipoma changed the title 1.2.16 Function expressions May 1, 2022
danipoma
danipoma reviewed Jul 24, 2022
View reviewed changes
danipoma
danipoma reviewed Jul 24, 2022
View reviewed changes
danipoma
danipoma reviewed Jul 24, 2022
View reviewed changes
danipoma
danipoma requested changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@danipoma danipoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed two paragraphs since they were not in source files anymore and also changed some text without suggestion since it was clear translation inconsistency.

Please take a look on my suggestions.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jul 24, 2022
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@otmon76
Copy link
Contributor Author

otmon76 commented Jul 25, 2022

"Removed two paragraphs since they were not in source files anymore and also changed some text without suggestion since it was clear translation inconsistency."
this is true, I didn't notice that the two paragraphs were removed

@otmon76 otmon76 merged commit 5a10b48 into javascript-tutorial:master Jul 25, 2022
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 25, 2022
Open
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@otmon76
Copy link
Contributor Author

otmon76 commented Jul 25, 2022

I am sorry I mistakenly merged it but the suggestions were applied.

@otmon76
Copy link
Contributor Author

otmon76 commented Jul 25, 2022

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jul 25, 2022
@javascript-translate-bot javascript-translate-bot requested a review from a team July 25, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danipoma danipoma danipoma requested changes

Assignees
No one assigned
Labels
review needed Review needed, please approve or request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otmon76 @javascript-translate-bot @danipoma