Skip to content

plan9 port maintenance#1756

Open
pixelherodev wants to merge 2 commits into
janet-lang:masterfrom
pixelherodev:master
Open

plan9 port maintenance#1756
pixelherodev wants to merge 2 commits into
janet-lang:masterfrom
pixelherodev:master

Conversation

@pixelherodev
Copy link
Copy Markdown

Fixes a few regressions since the port initially landed

@pixelherodev
Copy link
Copy Markdown
Author

This partly reverts the opaquing of JanetMarshalContext, so cc @iceghost.

I'd like to find a way to fix compilation on plan9 without reverting that, since that seems to be an intentional change?

@iceghost
Copy link
Copy Markdown
Contributor

I thought CI also covers Plan9. I'm not sure how to build for Plan9 yet, but I will take a look when I get home in like 9 hours.

(it would be nice if you could include why it failed, since it is not apparent on the commit diff)

@iceghost
Copy link
Copy Markdown
Contributor

Ah, downloading the ISO from https://9front.org is such a pain in the ass with all the rate limiting on their side. My downloads keep on timing out.

I would recommend putting the compile errors here so people who don't have access to a Plan 9 installation could help review this pull request for you. Otherwise the change does not make sense to me.

(Also I think you should fix your system clock...? The commits appear to be authored in 2023)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants