Skip to content

feat(compatible-products): add thunisoft as 3.1 to jakarta ee 10 platform #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliviergoulet5 merged 6 commits into from
Jan 21, 2026
Merged

feat(compatible-products): add thunisoft as 3.1 to jakarta ee 10 platform #2350

oliviergoulet5 merged 6 commits into from
Jan 21, 2026

Conversation

@oliviergoulet5
Copy link
Member

@oliviergoulet5 oliviergoulet5 commented Jan 5, 2026

Resolves #2347

@oliviergoulet5 oliviergoulet5 self-assigned this Jan 5, 2026
@netlify
Copy link

netlify bot commented Jan 5, 2026 •
edited
Loading

✅ Deploy Preview for jakartaee ready!

Name Link
🔨 Latest commit 3c30120
🔍 Latest deploy log https://app.netlify.com/projects/jakartaee/deploys/69712c7419b2b50008a42073
😎 Deploy Preview https://deploy-preview-2350--jakartaee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

autumnfound
autumnfound reviewed Jan 5, 2026
View reviewed changes
data/compatible_products.yml Outdated
vendor: Beijing Thunisoft Information Technology Co.,Ltd
image: '/images/compatible_products/tas-logo.png'
image_width: 200
download: 'http://tas.thunisoft.com/download'
Copy link
Contributor

@autumnfound autumnfound Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL leads to a dead page, no redirect

@oliviergoulet5 oliviergoulet5 force-pushed the oliviergoulet/main/2347 branch from 255d090 to d7ed2fa Compare January 14, 2026 16:25
autumnfound
autumnfound reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@autumnfound autumnfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://thunisoft.com/tasyyzjj/index.html Still seems to be a dead link, and adding www. leads to a host-blocked page. I'm thinking this might be a China-only page, which I'm not sure how we want to handle.

@oliviergoulet5
Copy link
Member Author

oliviergoulet5 commented Jan 14, 2026

Still seems to be a dead link, and adding www. leads to a host-blocked page. I'm thinking this might be a China-only page, which I'm not sure how we want to handle.

Fixed, sorry I was focused on the IP-block and didn't test the other links. I reached out to Tanja to discuss how we should proceed. We will ask for help from one of our committee members who is based in China to validate.

@oliviergoulet5 oliviergoulet5 marked this pull request as ready for review January 20, 2026 18:07
@oliviergoulet5
Copy link
Member Author

oliviergoulet5 commented Jan 20, 2026

Issues are fixed

@oliviergoulet5 oliviergoulet5 merged commit 194a3ae into src Jan 21, 2026
4 of 5 checks passed
@oliviergoulet5 oliviergoulet5 deleted the oliviergoulet/main/2347 branch January 21, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@autumnfound autumnfound autumnfound left review comments

@ericpoirier ericpoirier ericpoirier approved these changes

@gnugomez gnugomez gnugomez approved these changes

Assignees

@oliviergoulet5 oliviergoulet5

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add Thunisoft Application Server V3.1 as Compatible product of Jakarta EE 10 Full Platform

5 participants

@oliviergoulet5 @ericpoirier @autumnfound @gnugomez