feat: add DarkModeToggle with lucide icons and theme handling#32
Open
maneeshkumarr wants to merge 1 commit intoixartz:masterfrom
Open
feat: add DarkModeToggle with lucide icons and theme handling#32maneeshkumarr wants to merge 1 commit intoixartz:masterfrom
maneeshkumarr wants to merge 1 commit intoixartz:masterfrom
Conversation
Author
|
Uploading Screen Recording 2025-07-04 151831.mp4… |
Owner
|
Should I start reviewing it? |
Author
|
yes please.. |
Author
|
please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DarkModeToggleincomponents/theme/DarkModeToggle.tsx.next-themespackage to manage theme switching (light/dark).lucide-reacticons (Sun,Moon) for a modern toggle button.dark:variants for theme-based appearance.How it works
lightanddarkmode usingsetTheme().resolvedThemeto determine current theme.Note
Dark mode toggle is functional ✅
However, some components use hardcoded colors like
text-blackorbg-white, causing poor contrast in dark mode.🔧 Tracked in a separate issue: #4 >